Fix segfaults attribute to missing options

In cases where the remote client culls options to a command, we need to
be sure that the lookup for that flag does not result in a nil pointer.
To do so, we add a Remote attribute to the podman struct and then cli
helper funcs are now aware they are remote.

Signed-off-by: baude <bbaude@redhat.com>
This commit is contained in:
baude
2019-04-15 09:53:38 -05:00
parent 6e1dab76e2
commit 6fb0a706af
77 changed files with 106 additions and 10 deletions

View File

@ -17,6 +17,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
attachCommand.InputArgs = args attachCommand.InputArgs = args
attachCommand.GlobalFlags = MainGlobalOpts attachCommand.GlobalFlags = MainGlobalOpts
attachCommand.Remote = remoteclient
return attachCmd(&attachCommand) return attachCmd(&attachCommand)
}, },
Example: `podman attach ctrID Example: `podman attach ctrID

View File

@ -39,6 +39,7 @@ var (
buildCommand.FromAndBudResults = &fromAndBudValues buildCommand.FromAndBudResults = &fromAndBudValues
buildCommand.LayerResults = &layerValues buildCommand.LayerResults = &layerValues
buildCommand.NameSpaceResults = &namespaceValues buildCommand.NameSpaceResults = &namespaceValues
buildCommand.Remote = remoteclient
return buildCmd(&buildCommand) return buildCmd(&buildCommand)
}, },
Example: `podman build . Example: `podman build .

View File

@ -23,6 +23,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
checkpointCommand.InputArgs = args checkpointCommand.InputArgs = args
checkpointCommand.GlobalFlags = MainGlobalOpts checkpointCommand.GlobalFlags = MainGlobalOpts
checkpointCommand.Remote = remoteclient
return checkpointCmd(&checkpointCommand) return checkpointCmd(&checkpointCommand)
}, },
Args: func(cmd *cobra.Command, args []string) error { Args: func(cmd *cobra.Command, args []string) error {

View File

@ -24,6 +24,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
cleanupCommand.InputArgs = args cleanupCommand.InputArgs = args
cleanupCommand.GlobalFlags = MainGlobalOpts cleanupCommand.GlobalFlags = MainGlobalOpts
cleanupCommand.Remote = remoteclient
return cleanupCmd(&cleanupCommand) return cleanupCmd(&cleanupCommand)
}, },
Args: func(cmd *cobra.Command, args []string) error { Args: func(cmd *cobra.Command, args []string) error {

View File

@ -26,7 +26,9 @@ func (p *PodmanCommand) IsSet(opt string) bool {
func (p *PodmanCommand) Bool(opt string) bool { func (p *PodmanCommand) Bool(opt string) bool {
flag := p.Flags().Lookup(opt) flag := p.Flags().Lookup(opt)
if flag == nil { if flag == nil {
logrus.Errorf("Could not find flag %s", opt) if !p.Remote {
logrus.Errorf("Could not find flag %s", opt)
}
return false return false
} }
val, err := p.Flags().GetBool(opt) val, err := p.Flags().GetBool(opt)
@ -40,7 +42,9 @@ func (p *PodmanCommand) Bool(opt string) bool {
func (p *PodmanCommand) String(opt string) string { func (p *PodmanCommand) String(opt string) string {
flag := p.Flags().Lookup(opt) flag := p.Flags().Lookup(opt)
if flag == nil { if flag == nil {
logrus.Errorf("Could not find flag %s", opt) if !p.Remote {
logrus.Errorf("Could not find flag %s", opt)
}
return "" return ""
} }
val, err := p.Flags().GetString(opt) val, err := p.Flags().GetString(opt)
@ -54,7 +58,9 @@ func (p *PodmanCommand) String(opt string) string {
func (p *PodmanCommand) StringArray(opt string) []string { func (p *PodmanCommand) StringArray(opt string) []string {
flag := p.Flags().Lookup(opt) flag := p.Flags().Lookup(opt)
if flag == nil { if flag == nil {
logrus.Errorf("Could not find flag %s", opt) if !p.Remote {
logrus.Errorf("Could not find flag %s", opt)
}
return []string{} return []string{}
} }
val, err := p.Flags().GetStringArray(opt) val, err := p.Flags().GetStringArray(opt)
@ -68,7 +74,9 @@ func (p *PodmanCommand) StringArray(opt string) []string {
func (p *PodmanCommand) StringSlice(opt string) []string { func (p *PodmanCommand) StringSlice(opt string) []string {
flag := p.Flags().Lookup(opt) flag := p.Flags().Lookup(opt)
if flag == nil { if flag == nil {
logrus.Errorf("Could not find flag %s", opt) if !p.Remote {
logrus.Errorf("Could not find flag %s", opt)
}
return []string{} return []string{}
} }
val, err := p.Flags().GetStringSlice(opt) val, err := p.Flags().GetStringSlice(opt)
@ -82,7 +90,9 @@ func (p *PodmanCommand) StringSlice(opt string) []string {
func (p *PodmanCommand) Int(opt string) int { func (p *PodmanCommand) Int(opt string) int {
flag := p.Flags().Lookup(opt) flag := p.Flags().Lookup(opt)
if flag == nil { if flag == nil {
logrus.Errorf("Could not find flag %s", opt) if !p.Remote {
logrus.Errorf("Could not find flag %s", opt)
}
return 0 return 0
} }
val, err := p.Flags().GetInt(opt) val, err := p.Flags().GetInt(opt)
@ -96,7 +106,9 @@ func (p *PodmanCommand) Int(opt string) int {
func (p *PodmanCommand) Uint(opt string) uint { func (p *PodmanCommand) Uint(opt string) uint {
flag := p.Flags().Lookup(opt) flag := p.Flags().Lookup(opt)
if flag == nil { if flag == nil {
logrus.Errorf("Could not find flag %s", opt) if !p.Remote {
logrus.Errorf("Could not find flag %s", opt)
}
return 0 return 0
} }
val, err := p.Flags().GetUint(opt) val, err := p.Flags().GetUint(opt)
@ -110,7 +122,9 @@ func (p *PodmanCommand) Uint(opt string) uint {
func (p *PodmanCommand) Int64(opt string) int64 { func (p *PodmanCommand) Int64(opt string) int64 {
flag := p.Flags().Lookup(opt) flag := p.Flags().Lookup(opt)
if flag == nil { if flag == nil {
logrus.Errorf("Could not find flag %s", opt) if !p.Remote {
logrus.Errorf("Could not find flag %s", opt)
}
return 0 return 0
} }
val, err := p.Flags().GetInt64(opt) val, err := p.Flags().GetInt64(opt)
@ -124,7 +138,9 @@ func (p *PodmanCommand) Int64(opt string) int64 {
func (p *PodmanCommand) Uint64(opt string) uint64 { func (p *PodmanCommand) Uint64(opt string) uint64 {
flag := p.Flags().Lookup(opt) flag := p.Flags().Lookup(opt)
if flag == nil { if flag == nil {
logrus.Errorf("Could not find flag %s", opt) if !p.Remote {
logrus.Errorf("Could not find flag %s", opt)
}
return 0 return 0
} }
val, err := p.Flags().GetUint64(opt) val, err := p.Flags().GetUint64(opt)
@ -138,7 +154,9 @@ func (p *PodmanCommand) Uint64(opt string) uint64 {
func (p *PodmanCommand) Float64(opt string) float64 { func (p *PodmanCommand) Float64(opt string) float64 {
flag := p.Flags().Lookup(opt) flag := p.Flags().Lookup(opt)
if flag == nil { if flag == nil {
logrus.Errorf("Could not find flag %s", opt) if !p.Remote {
logrus.Errorf("Could not find flag %s", opt)
}
return 0 return 0
} }
val, err := p.Flags().GetFloat64(opt) val, err := p.Flags().GetFloat64(opt)

View File

@ -8,6 +8,7 @@ type PodmanCommand struct {
*cobra.Command *cobra.Command
InputArgs []string InputArgs []string
GlobalFlags MainFlags GlobalFlags MainFlags
Remote bool
} }
type MainFlags struct { type MainFlags struct {

View File

@ -28,6 +28,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
commitCommand.InputArgs = args commitCommand.InputArgs = args
commitCommand.GlobalFlags = MainGlobalOpts commitCommand.GlobalFlags = MainGlobalOpts
commitCommand.Remote = remoteclient
return commitCmd(&commitCommand) return commitCmd(&commitCommand)
}, },
Example: `podman commit -q --message "committing container to image" reverent_golick image-commited Example: `podman commit -q --message "committing container to image" reverent_golick image-commited

View File

@ -27,6 +27,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
pruneContainersCommand.InputArgs = args pruneContainersCommand.InputArgs = args
pruneContainersCommand.GlobalFlags = MainGlobalOpts pruneContainersCommand.GlobalFlags = MainGlobalOpts
pruneContainersCommand.Remote = remoteclient
return pruneContainersCmd(&pruneContainersCommand) return pruneContainersCmd(&pruneContainersCommand)
}, },
} }

View File

@ -36,6 +36,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
cpCommand.InputArgs = args cpCommand.InputArgs = args
cpCommand.GlobalFlags = MainGlobalOpts cpCommand.GlobalFlags = MainGlobalOpts
cpCommand.Remote = remoteclient
return cpCmd(&cpCommand) return cpCmd(&cpCommand)
}, },
Example: "[CONTAINER:]SRC_PATH [CONTAINER:]DEST_PATH", Example: "[CONTAINER:]SRC_PATH [CONTAINER:]DEST_PATH",

View File

@ -22,6 +22,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
createCommand.InputArgs = args createCommand.InputArgs = args
createCommand.GlobalFlags = MainGlobalOpts createCommand.GlobalFlags = MainGlobalOpts
createCommand.Remote = remoteclient
return createCmd(&createCommand) return createCmd(&createCommand)
}, },
Example: `podman create alpine ls Example: `podman create alpine ls

View File

@ -43,6 +43,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
diffCommand.InputArgs = args diffCommand.InputArgs = args
diffCommand.GlobalFlags = MainGlobalOpts diffCommand.GlobalFlags = MainGlobalOpts
diffCommand.Remote = remoteclient
return diffCmd(&diffCommand) return diffCmd(&diffCommand)
}, },
Example: `podman diff imageID Example: `podman diff imageID

View File

@ -18,6 +18,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
eventsCommand.InputArgs = args eventsCommand.InputArgs = args
eventsCommand.GlobalFlags = MainGlobalOpts eventsCommand.GlobalFlags = MainGlobalOpts
eventsCommand.Remote = remoteclient
return eventsCmd(&eventsCommand) return eventsCmd(&eventsCommand)
}, },
Example: `podman events Example: `podman events

View File

@ -26,6 +26,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
execCommand.InputArgs = args execCommand.InputArgs = args
execCommand.GlobalFlags = MainGlobalOpts execCommand.GlobalFlags = MainGlobalOpts
execCommand.Remote = remoteclient
return execCmd(&execCommand) return execCmd(&execCommand)
}, },
Example: `podman exec -it ctrID ls Example: `podman exec -it ctrID ls

View File

@ -29,6 +29,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
imageExistsCommand.InputArgs = args imageExistsCommand.InputArgs = args
imageExistsCommand.GlobalFlags = MainGlobalOpts imageExistsCommand.GlobalFlags = MainGlobalOpts
imageExistsCommand.Remote = remoteclient
return imageExistsCmd(&imageExistsCommand) return imageExistsCmd(&imageExistsCommand)
}, },
Example: `podman image exists imageID Example: `podman image exists imageID
@ -42,6 +43,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
containerExistsCommand.InputArgs = args containerExistsCommand.InputArgs = args
containerExistsCommand.GlobalFlags = MainGlobalOpts containerExistsCommand.GlobalFlags = MainGlobalOpts
containerExistsCommand.Remote = remoteclient
return containerExistsCmd(&containerExistsCommand) return containerExistsCmd(&containerExistsCommand)
}, },
@ -56,6 +58,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
podExistsCommand.InputArgs = args podExistsCommand.InputArgs = args
podExistsCommand.GlobalFlags = MainGlobalOpts podExistsCommand.GlobalFlags = MainGlobalOpts
podExistsCommand.Remote = remoteclient
return podExistsCmd(&podExistsCommand) return podExistsCmd(&podExistsCommand)
}, },
Example: `podman pod exists podID Example: `podman pod exists podID

View File

@ -23,6 +23,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
exportCommand.InputArgs = args exportCommand.InputArgs = args
exportCommand.GlobalFlags = MainGlobalOpts exportCommand.GlobalFlags = MainGlobalOpts
exportCommand.Remote = remoteclient
return exportCmd(&exportCommand) return exportCmd(&exportCommand)
}, },
Example: `podman export ctrID > myCtr.tar Example: `podman export ctrID > myCtr.tar

View File

@ -22,6 +22,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
containerKubeCommand.InputArgs = args containerKubeCommand.InputArgs = args
containerKubeCommand.GlobalFlags = MainGlobalOpts containerKubeCommand.GlobalFlags = MainGlobalOpts
containerKubeCommand.Remote = remoteclient
return generateKubeYAMLCmd(&containerKubeCommand) return generateKubeYAMLCmd(&containerKubeCommand)
}, },
Example: `podman generate kube ctrID Example: `podman generate kube ctrID

View File

@ -20,6 +20,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
healthcheckRunCommand.InputArgs = args healthcheckRunCommand.InputArgs = args
healthcheckRunCommand.GlobalFlags = MainGlobalOpts healthcheckRunCommand.GlobalFlags = MainGlobalOpts
healthcheckRunCommand.Remote = remoteclient
return healthCheckCmd(&healthcheckRunCommand) return healthCheckCmd(&healthcheckRunCommand)
}, },
Args: func(cmd *cobra.Command, args []string) error { Args: func(cmd *cobra.Command, args []string) error {

View File

@ -47,6 +47,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
historyCommand.InputArgs = args historyCommand.InputArgs = args
historyCommand.GlobalFlags = MainGlobalOpts historyCommand.GlobalFlags = MainGlobalOpts
historyCommand.Remote = remoteclient
return historyCmd(&historyCommand) return historyCmd(&historyCommand)
}, },
} }

View File

@ -96,6 +96,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
imagesCommand.InputArgs = args imagesCommand.InputArgs = args
imagesCommand.GlobalFlags = MainGlobalOpts imagesCommand.GlobalFlags = MainGlobalOpts
imagesCommand.Remote = remoteclient
return imagesCmd(&imagesCommand) return imagesCmd(&imagesCommand)
}, },
Example: `podman images --format json Example: `podman images --format json

View File

@ -22,6 +22,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
pruneImagesCommand.InputArgs = args pruneImagesCommand.InputArgs = args
pruneImagesCommand.GlobalFlags = MainGlobalOpts pruneImagesCommand.GlobalFlags = MainGlobalOpts
pruneImagesCommand.Remote = remoteclient
return pruneImagesCmd(&pruneImagesCommand) return pruneImagesCmd(&pruneImagesCommand)
}, },
} }

View File

@ -24,6 +24,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
importCommand.InputArgs = args importCommand.InputArgs = args
importCommand.GlobalFlags = MainGlobalOpts importCommand.GlobalFlags = MainGlobalOpts
importCommand.Remote = remoteclient
return importCmd(&importCommand) return importCmd(&importCommand)
}, },
Example: `podman import http://example.com/ctr.tar url-image Example: `podman import http://example.com/ctr.tar url-image

View File

@ -28,6 +28,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
infoCommand.InputArgs = args infoCommand.InputArgs = args
infoCommand.GlobalFlags = MainGlobalOpts infoCommand.GlobalFlags = MainGlobalOpts
infoCommand.Remote = remoteclient
return infoCmd(&infoCommand) return infoCmd(&infoCommand)
}, },
Example: `podman info`, Example: `podman info`,

View File

@ -33,6 +33,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
inspectCommand.InputArgs = args inspectCommand.InputArgs = args
inspectCommand.GlobalFlags = MainGlobalOpts inspectCommand.GlobalFlags = MainGlobalOpts
inspectCommand.Remote = remoteclient
return inspectCmd(&inspectCommand) return inspectCmd(&inspectCommand)
}, },
Example: `podman inspect alpine Example: `podman inspect alpine

View File

@ -20,6 +20,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
killCommand.InputArgs = args killCommand.InputArgs = args
killCommand.GlobalFlags = MainGlobalOpts killCommand.GlobalFlags = MainGlobalOpts
killCommand.Remote = remoteclient
return killCmd(&killCommand) return killCmd(&killCommand)
}, },
Args: func(cmd *cobra.Command, args []string) error { Args: func(cmd *cobra.Command, args []string) error {

View File

@ -27,6 +27,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
loadCommand.InputArgs = args loadCommand.InputArgs = args
loadCommand.GlobalFlags = MainGlobalOpts loadCommand.GlobalFlags = MainGlobalOpts
loadCommand.Remote = remoteclient
return loadCmd(&loadCommand) return loadCmd(&loadCommand)
}, },
} }

View File

@ -27,6 +27,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
loginCommand.InputArgs = args loginCommand.InputArgs = args
loginCommand.GlobalFlags = MainGlobalOpts loginCommand.GlobalFlags = MainGlobalOpts
loginCommand.Remote = remoteclient
return loginCmd(&loginCommand) return loginCmd(&loginCommand)
}, },
Example: `podman login -u testuser -p testpassword localhost:5000 Example: `podman login -u testuser -p testpassword localhost:5000

View File

@ -20,6 +20,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
logoutCommand.InputArgs = args logoutCommand.InputArgs = args
logoutCommand.GlobalFlags = MainGlobalOpts logoutCommand.GlobalFlags = MainGlobalOpts
logoutCommand.Remote = remoteclient
return logoutCmd(&logoutCommand) return logoutCmd(&logoutCommand)
}, },
Example: `podman logout docker.io Example: `podman logout docker.io

View File

@ -24,6 +24,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
logsCommand.InputArgs = args logsCommand.InputArgs = args
logsCommand.GlobalFlags = MainGlobalOpts logsCommand.GlobalFlags = MainGlobalOpts
logsCommand.Remote = remoteclient
return logsCmd(&logsCommand) return logsCmd(&logsCommand)
}, },
Args: func(cmd *cobra.Command, args []string) error { Args: func(cmd *cobra.Command, args []string) error {

View File

@ -110,6 +110,7 @@ func setupRootless(cmd *cobra.Command, args []string) error {
cmd, cmd,
args, args,
MainGlobalOpts, MainGlobalOpts,
remoteclient,
} }
runtime, err := libpodruntime.GetRuntime(&podmanCmd) runtime, err := libpodruntime.GetRuntime(&podmanCmd)
if err != nil { if err != nil {

View File

@ -31,6 +31,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
mountCommand.InputArgs = args mountCommand.InputArgs = args
mountCommand.GlobalFlags = MainGlobalOpts mountCommand.GlobalFlags = MainGlobalOpts
mountCommand.Remote = remoteclient
return mountCmd(&mountCommand) return mountCmd(&mountCommand)
}, },
Args: func(cmd *cobra.Command, args []string) error { Args: func(cmd *cobra.Command, args []string) error {

View File

@ -22,6 +22,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
pauseCommand.InputArgs = args pauseCommand.InputArgs = args
pauseCommand.GlobalFlags = MainGlobalOpts pauseCommand.GlobalFlags = MainGlobalOpts
pauseCommand.Remote = remoteclient
return pauseCmd(&pauseCommand) return pauseCmd(&pauseCommand)
}, },
Example: `podman pause mywebserver Example: `podman pause mywebserver

View File

@ -42,6 +42,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
playKubeCommand.InputArgs = args playKubeCommand.InputArgs = args
playKubeCommand.GlobalFlags = MainGlobalOpts playKubeCommand.GlobalFlags = MainGlobalOpts
playKubeCommand.Remote = remoteclient
return playKubeYAMLCmd(&playKubeCommand) return playKubeYAMLCmd(&playKubeCommand)
}, },
Example: `podman play kube demo.yml Example: `podman play kube demo.yml

View File

@ -30,6 +30,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
podCreateCommand.InputArgs = args podCreateCommand.InputArgs = args
podCreateCommand.GlobalFlags = MainGlobalOpts podCreateCommand.GlobalFlags = MainGlobalOpts
podCreateCommand.Remote = remoteclient
return podCreateCmd(&podCreateCommand) return podCreateCmd(&podCreateCommand)
}, },
} }

View File

@ -22,6 +22,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
podInspectCommand.InputArgs = args podInspectCommand.InputArgs = args
podInspectCommand.GlobalFlags = MainGlobalOpts podInspectCommand.GlobalFlags = MainGlobalOpts
podInspectCommand.Remote = remoteclient
return podInspectCmd(&podInspectCommand) return podInspectCmd(&podInspectCommand)
}, },
Example: `podman pod inspect podID`, Example: `podman pod inspect podID`,

View File

@ -24,6 +24,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
podKillCommand.InputArgs = args podKillCommand.InputArgs = args
podKillCommand.GlobalFlags = MainGlobalOpts podKillCommand.GlobalFlags = MainGlobalOpts
podKillCommand.Remote = remoteclient
return podKillCmd(&podKillCommand) return podKillCmd(&podKillCommand)
}, },
Args: func(cmd *cobra.Command, args []string) error { Args: func(cmd *cobra.Command, args []string) error {

View File

@ -21,6 +21,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
podPauseCommand.InputArgs = args podPauseCommand.InputArgs = args
podPauseCommand.GlobalFlags = MainGlobalOpts podPauseCommand.GlobalFlags = MainGlobalOpts
podPauseCommand.Remote = remoteclient
return podPauseCmd(&podPauseCommand) return podPauseCmd(&podPauseCommand)
}, },
Args: func(cmd *cobra.Command, args []string) error { Args: func(cmd *cobra.Command, args []string) error {

View File

@ -127,6 +127,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
podPsCommand.InputArgs = args podPsCommand.InputArgs = args
podPsCommand.GlobalFlags = MainGlobalOpts podPsCommand.GlobalFlags = MainGlobalOpts
podPsCommand.Remote = remoteclient
return podPsCmd(&podPsCommand) return podPsCmd(&podPsCommand)
}, },
} }

View File

@ -22,6 +22,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
podRestartCommand.InputArgs = args podRestartCommand.InputArgs = args
podRestartCommand.GlobalFlags = MainGlobalOpts podRestartCommand.GlobalFlags = MainGlobalOpts
podRestartCommand.Remote = remoteclient
return podRestartCmd(&podRestartCommand) return podRestartCmd(&podRestartCommand)
}, },
Args: func(cmd *cobra.Command, args []string) error { Args: func(cmd *cobra.Command, args []string) error {

View File

@ -22,6 +22,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
podRmCommand.InputArgs = args podRmCommand.InputArgs = args
podRmCommand.GlobalFlags = MainGlobalOpts podRmCommand.GlobalFlags = MainGlobalOpts
podRmCommand.Remote = remoteclient
return podRmCmd(&podRmCommand) return podRmCmd(&podRmCommand)
}, },
Args: func(cmd *cobra.Command, args []string) error { Args: func(cmd *cobra.Command, args []string) error {

View File

@ -22,6 +22,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
podStartCommand.InputArgs = args podStartCommand.InputArgs = args
podStartCommand.GlobalFlags = MainGlobalOpts podStartCommand.GlobalFlags = MainGlobalOpts
podStartCommand.Remote = remoteclient
return podStartCmd(&podStartCommand) return podStartCmd(&podStartCommand)
}, },
Args: func(cmd *cobra.Command, args []string) error { Args: func(cmd *cobra.Command, args []string) error {

View File

@ -29,6 +29,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
podStatsCommand.InputArgs = args podStatsCommand.InputArgs = args
podStatsCommand.GlobalFlags = MainGlobalOpts podStatsCommand.GlobalFlags = MainGlobalOpts
podStatsCommand.Remote = remoteclient
return podStatsCmd(&podStatsCommand) return podStatsCmd(&podStatsCommand)
}, },
Example: `podman stats -a --no-stream Example: `podman stats -a --no-stream

View File

@ -23,6 +23,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
podStopCommand.InputArgs = args podStopCommand.InputArgs = args
podStopCommand.GlobalFlags = MainGlobalOpts podStopCommand.GlobalFlags = MainGlobalOpts
podStopCommand.Remote = remoteclient
return podStopCmd(&podStopCommand) return podStopCmd(&podStopCommand)
}, },
Args: func(cmd *cobra.Command, args []string) error { Args: func(cmd *cobra.Command, args []string) error {

View File

@ -28,6 +28,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
podTopCommand.InputArgs = args podTopCommand.InputArgs = args
podTopCommand.GlobalFlags = MainGlobalOpts podTopCommand.GlobalFlags = MainGlobalOpts
podTopCommand.Remote = remoteclient
return podTopCmd(&podTopCommand) return podTopCmd(&podTopCommand)
}, },
Example: `podman top ctrID Example: `podman top ctrID

View File

@ -22,6 +22,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
podUnpauseCommand.InputArgs = args podUnpauseCommand.InputArgs = args
podUnpauseCommand.GlobalFlags = MainGlobalOpts podUnpauseCommand.GlobalFlags = MainGlobalOpts
podUnpauseCommand.Remote = remoteclient
return podUnpauseCmd(&podUnpauseCommand) return podUnpauseCmd(&podUnpauseCommand)
}, },
Args: func(cmd *cobra.Command, args []string) error { Args: func(cmd *cobra.Command, args []string) error {

View File

@ -23,6 +23,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
portCommand.InputArgs = args portCommand.InputArgs = args
portCommand.GlobalFlags = MainGlobalOpts portCommand.GlobalFlags = MainGlobalOpts
portCommand.Remote = remoteclient
return portCmd(&portCommand) return portCmd(&portCommand)
}, },
Args: func(cmd *cobra.Command, args []string) error { Args: func(cmd *cobra.Command, args []string) error {

View File

@ -161,6 +161,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
psCommand.InputArgs = args psCommand.InputArgs = args
psCommand.GlobalFlags = MainGlobalOpts psCommand.GlobalFlags = MainGlobalOpts
psCommand.Remote = remoteclient
return psCmd(&psCommand) return psCmd(&psCommand)
}, },
Example: `podman ps -a Example: `podman ps -a

View File

@ -32,6 +32,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
pullCommand.InputArgs = args pullCommand.InputArgs = args
pullCommand.GlobalFlags = MainGlobalOpts pullCommand.GlobalFlags = MainGlobalOpts
pullCommand.Remote = remoteclient
return pullCmd(&pullCommand) return pullCmd(&pullCommand)
}, },
Example: `podman pull imageName Example: `podman pull imageName
@ -117,7 +118,7 @@ func pullCmd(c *cliconfig.PullValues) (retError error) {
DockerRegistryCreds: registryCreds, DockerRegistryCreds: registryCreds,
DockerCertPath: c.CertDir, DockerCertPath: c.CertDir,
} }
if c.Flag("tls-verify").Changed { if c.IsSet("tls-verify") {
dockerRegistryOptions.DockerInsecureSkipTLSVerify = types.NewOptionalBool(!c.TlsVerify) dockerRegistryOptions.DockerInsecureSkipTLSVerify = types.NewOptionalBool(!c.TlsVerify)
} }

View File

@ -31,6 +31,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
pushCommand.InputArgs = args pushCommand.InputArgs = args
pushCommand.GlobalFlags = MainGlobalOpts pushCommand.GlobalFlags = MainGlobalOpts
pushCommand.Remote = remoteclient
return pushCmd(&pushCommand) return pushCmd(&pushCommand)
}, },
Example: `podman push imageID docker://registry.example.com/repository:tag Example: `podman push imageID docker://registry.example.com/repository:tag

View File

@ -24,6 +24,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
refreshCommand.InputArgs = args refreshCommand.InputArgs = args
refreshCommand.GlobalFlags = MainGlobalOpts refreshCommand.GlobalFlags = MainGlobalOpts
refreshCommand.Remote = remoteclient
return refreshCmd(&refreshCommand) return refreshCmd(&refreshCommand)
}, },
} }

View File

@ -22,6 +22,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
restartCommand.InputArgs = args restartCommand.InputArgs = args
restartCommand.GlobalFlags = MainGlobalOpts restartCommand.GlobalFlags = MainGlobalOpts
restartCommand.Remote = remoteclient
return restartCmd(&restartCommand) return restartCmd(&restartCommand)
}, },
Args: func(cmd *cobra.Command, args []string) error { Args: func(cmd *cobra.Command, args []string) error {

View File

@ -23,6 +23,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
restoreCommand.InputArgs = args restoreCommand.InputArgs = args
restoreCommand.GlobalFlags = MainGlobalOpts restoreCommand.GlobalFlags = MainGlobalOpts
restoreCommand.Remote = remoteclient
return restoreCmd(&restoreCommand) return restoreCmd(&restoreCommand)
}, },
Args: func(cmd *cobra.Command, args []string) error { Args: func(cmd *cobra.Command, args []string) error {

View File

@ -22,6 +22,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
rmCommand.InputArgs = args rmCommand.InputArgs = args
rmCommand.GlobalFlags = MainGlobalOpts rmCommand.GlobalFlags = MainGlobalOpts
rmCommand.Remote = remoteclient
return rmCmd(&rmCommand) return rmCmd(&rmCommand)
}, },
Args: func(cmd *cobra.Command, args []string) error { Args: func(cmd *cobra.Command, args []string) error {

View File

@ -21,6 +21,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
rmiCommand.InputArgs = args rmiCommand.InputArgs = args
rmiCommand.GlobalFlags = MainGlobalOpts rmiCommand.GlobalFlags = MainGlobalOpts
rmiCommand.Remote = remoteclient
return rmiCmd(&rmiCommand) return rmiCmd(&rmiCommand)
}, },
Example: `podman rmi imageID Example: `podman rmi imageID

View File

@ -19,6 +19,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
runCommand.InputArgs = args runCommand.InputArgs = args
runCommand.GlobalFlags = MainGlobalOpts runCommand.GlobalFlags = MainGlobalOpts
runCommand.Remote = remoteclient
return runCmd(&runCommand) return runCmd(&runCommand)
}, },
Example: `podman run imageID ls -alF /etc Example: `podman run imageID ls -alF /etc

View File

@ -30,6 +30,7 @@ Executes a command as described by a container image label.
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
runlabelCommand.InputArgs = args runlabelCommand.InputArgs = args
runlabelCommand.GlobalFlags = MainGlobalOpts runlabelCommand.GlobalFlags = MainGlobalOpts
runlabelCommand.Remote = remoteclient
return runlabelCmd(&runlabelCommand) return runlabelCmd(&runlabelCommand)
}, },
Example: `podman container runlabel run imageID Example: `podman container runlabel run imageID

View File

@ -33,6 +33,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
saveCommand.InputArgs = args saveCommand.InputArgs = args
saveCommand.GlobalFlags = MainGlobalOpts saveCommand.GlobalFlags = MainGlobalOpts
saveCommand.Remote = remoteclient
return saveCmd(&saveCommand) return saveCmd(&saveCommand)
}, },
Args: func(cmd *cobra.Command, args []string) error { Args: func(cmd *cobra.Command, args []string) error {

View File

@ -29,6 +29,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
searchCommand.InputArgs = args searchCommand.InputArgs = args
searchCommand.GlobalFlags = MainGlobalOpts searchCommand.GlobalFlags = MainGlobalOpts
searchCommand.Remote = remoteclient
return searchCmd(&searchCommand) return searchCmd(&searchCommand)
}, },
Example: `podman search --filter=is-official --limit 3 alpine Example: `podman search --filter=is-official --limit 3 alpine

View File

@ -30,6 +30,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
signCommand.InputArgs = args signCommand.InputArgs = args
signCommand.GlobalFlags = MainGlobalOpts signCommand.GlobalFlags = MainGlobalOpts
signCommand.Remote = remoteclient
return signCmd(&signCommand) return signCmd(&signCommand)
}, },
Example: `podman sign --sign-by mykey imageID Example: `podman sign --sign-by mykey imageID

View File

@ -25,6 +25,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
startCommand.InputArgs = args startCommand.InputArgs = args
startCommand.GlobalFlags = MainGlobalOpts startCommand.GlobalFlags = MainGlobalOpts
startCommand.Remote = remoteclient
return startCmd(&startCommand) return startCmd(&startCommand)
}, },
Example: `podman start --latest Example: `podman start --latest

View File

@ -39,6 +39,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
statsCommand.InputArgs = args statsCommand.InputArgs = args
statsCommand.GlobalFlags = MainGlobalOpts statsCommand.GlobalFlags = MainGlobalOpts
statsCommand.Remote = remoteclient
return statsCmd(&statsCommand) return statsCmd(&statsCommand)
}, },
Args: func(cmd *cobra.Command, args []string) error { Args: func(cmd *cobra.Command, args []string) error {

View File

@ -21,6 +21,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
stopCommand.InputArgs = args stopCommand.InputArgs = args
stopCommand.GlobalFlags = MainGlobalOpts stopCommand.GlobalFlags = MainGlobalOpts
stopCommand.Remote = remoteclient
return stopCmd(&stopCommand) return stopCmd(&stopCommand)
}, },
Args: func(cmd *cobra.Command, args []string) error { Args: func(cmd *cobra.Command, args []string) error {

View File

@ -33,6 +33,7 @@ var (
Long: dfSystemDescription, Long: dfSystemDescription,
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
dfSystemCommand.GlobalFlags = MainGlobalOpts dfSystemCommand.GlobalFlags = MainGlobalOpts
dfSystemCommand.Remote = remoteclient
return dfSystemCmd(&dfSystemCommand) return dfSystemCmd(&dfSystemCommand)
}, },
} }

View File

@ -29,6 +29,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
pruneSystemCommand.InputArgs = args pruneSystemCommand.InputArgs = args
pruneSystemCommand.GlobalFlags = MainGlobalOpts pruneSystemCommand.GlobalFlags = MainGlobalOpts
pruneSystemCommand.Remote = remoteclient
return pruneSystemCmd(&pruneSystemCommand) return pruneSystemCmd(&pruneSystemCommand)
}, },
} }

View File

@ -24,6 +24,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
renumberCommand.InputArgs = args renumberCommand.InputArgs = args
renumberCommand.GlobalFlags = MainGlobalOpts renumberCommand.GlobalFlags = MainGlobalOpts
renumberCommand.Remote = remoteclient
return renumberCmd(&renumberCommand) return renumberCmd(&renumberCommand)
}, },
} }

View File

@ -18,6 +18,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
tagCommand.InputArgs = args tagCommand.InputArgs = args
tagCommand.GlobalFlags = MainGlobalOpts tagCommand.GlobalFlags = MainGlobalOpts
tagCommand.Remote = remoteclient
return tagCmd(&tagCommand) return tagCmd(&tagCommand)
}, },
Example: `podman tag 0e3bbc2 fedora:latest Example: `podman tag 0e3bbc2 fedora:latest

View File

@ -39,6 +39,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
topCommand.InputArgs = args topCommand.InputArgs = args
topCommand.GlobalFlags = MainGlobalOpts topCommand.GlobalFlags = MainGlobalOpts
topCommand.Remote = remoteclient
return topCmd(&topCommand) return topCmd(&topCommand)
}, },
Example: `podman top ctrID Example: `podman top ctrID

View File

@ -29,6 +29,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
treeCommand.InputArgs = args treeCommand.InputArgs = args
treeCommand.GlobalFlags = MainGlobalOpts treeCommand.GlobalFlags = MainGlobalOpts
treeCommand.Remote = remoteclient
return treeCmd(&treeCommand) return treeCmd(&treeCommand)
}, },
Example: "podman image tree alpine:latest", Example: "podman image tree alpine:latest",

View File

@ -29,6 +29,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
setTrustCommand.InputArgs = args setTrustCommand.InputArgs = args
setTrustCommand.GlobalFlags = MainGlobalOpts setTrustCommand.GlobalFlags = MainGlobalOpts
setTrustCommand.Remote = remoteclient
return setTrustCmd(&setTrustCommand) return setTrustCmd(&setTrustCommand)
}, },
} }

View File

@ -24,6 +24,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
umountCommand.InputArgs = args umountCommand.InputArgs = args
umountCommand.GlobalFlags = MainGlobalOpts umountCommand.GlobalFlags = MainGlobalOpts
umountCommand.Remote = remoteclient
return umountCmd(&umountCommand) return umountCmd(&umountCommand)
}, },
Args: func(cmd *cobra.Command, args []string) error { Args: func(cmd *cobra.Command, args []string) error {

View File

@ -23,6 +23,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
unpauseCommand.InputArgs = args unpauseCommand.InputArgs = args
unpauseCommand.GlobalFlags = MainGlobalOpts unpauseCommand.GlobalFlags = MainGlobalOpts
unpauseCommand.Remote = remoteclient
return unpauseCmd(&unpauseCommand) return unpauseCmd(&unpauseCommand)
}, },
Example: `podman unpause ctrID Example: `podman unpause ctrID

View File

@ -23,6 +23,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
versionCommand.InputArgs = args versionCommand.InputArgs = args
versionCommand.GlobalFlags = MainGlobalOpts versionCommand.GlobalFlags = MainGlobalOpts
versionCommand.Remote = remoteclient
return versionCmd(&versionCommand) return versionCmd(&versionCommand)
}, },
} }

View File

@ -21,6 +21,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
volumeCreateCommand.InputArgs = args volumeCreateCommand.InputArgs = args
volumeCreateCommand.GlobalFlags = MainGlobalOpts volumeCreateCommand.GlobalFlags = MainGlobalOpts
volumeCreateCommand.Remote = remoteclient
return volumeCreateCmd(&volumeCreateCommand) return volumeCreateCmd(&volumeCreateCommand)
}, },
Example: `podman volume create myvol Example: `podman volume create myvol

View File

@ -19,6 +19,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
volumeInspectCommand.InputArgs = args volumeInspectCommand.InputArgs = args
volumeInspectCommand.GlobalFlags = MainGlobalOpts volumeInspectCommand.GlobalFlags = MainGlobalOpts
volumeInspectCommand.Remote = remoteclient
return volumeInspectCmd(&volumeInspectCommand) return volumeInspectCmd(&volumeInspectCommand)
}, },
Example: `podman volume inspect myvol Example: `podman volume inspect myvol

View File

@ -54,6 +54,7 @@ and the output format can be changed to JSON or a user specified Go template.`
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
volumeLsCommand.InputArgs = args volumeLsCommand.InputArgs = args
volumeLsCommand.GlobalFlags = MainGlobalOpts volumeLsCommand.GlobalFlags = MainGlobalOpts
volumeLsCommand.Remote = remoteclient
return volumeLsCmd(&volumeLsCommand) return volumeLsCmd(&volumeLsCommand)
}, },
} }

View File

@ -28,6 +28,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
volumePruneCommand.InputArgs = args volumePruneCommand.InputArgs = args
volumePruneCommand.GlobalFlags = MainGlobalOpts volumePruneCommand.GlobalFlags = MainGlobalOpts
volumePruneCommand.Remote = remoteclient
return volumePruneCmd(&volumePruneCommand) return volumePruneCmd(&volumePruneCommand)
}, },
} }

View File

@ -22,6 +22,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
volumeRmCommand.InputArgs = args volumeRmCommand.InputArgs = args
volumeRmCommand.GlobalFlags = MainGlobalOpts volumeRmCommand.GlobalFlags = MainGlobalOpts
volumeRmCommand.Remote = remoteclient
return volumeRmCmd(&volumeRmCommand) return volumeRmCmd(&volumeRmCommand)
}, },
Example: `podman volume rm myvol1 myvol2 Example: `podman volume rm myvol1 myvol2

View File

@ -21,6 +21,7 @@ var (
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
waitCommand.InputArgs = args waitCommand.InputArgs = args
waitCommand.GlobalFlags = MainGlobalOpts waitCommand.GlobalFlags = MainGlobalOpts
waitCommand.Remote = remoteclient
return waitCmd(&waitCommand) return waitCmd(&waitCommand)
}, },
Example: `podman wait --latest Example: `podman wait --latest