opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-05-23 10:07:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

Change podman build --pull=true to PullIfMissing

Browse Source 
One last tweak to the man page for 'build --pull' and after
further testing against Docker, one slight change to the
pull policy.  First I changed `--pull=false` from PullNever
to PullIfMissing.  This matches Docker and will pull the
image if it's not present rather than erroring.  We've
the `--pull-never` option if someone wants the pull to
not do an actual pull and to error if the image isn't
local.

Then for the man page, I'd a much bigger change, in the
initial PR, I've backed most of that out and just
added a tweak.

Hopefully this puts this portion of the pull work behind
us for a while.

Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
This commit is contained in:
TomSweeneyRedHat
2020-11-10 19:45:36 -05:00
parent 2fc2d4643e
commit 6ea13fd872
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/podman/images/build.go
View File

@ -249,7 +249,7 @@ func buildFlagsWrapperToOptions(c *cobra.Command, contextDir string, flags *buil
} }
if flags.PullNever { if flags.PullNever {
pullPolicy = imagebuildah.PullNever pullPolicy = imagebuildah.PullIfMissing
} }
args := make(map[string]string) args := make(map[string]string)

4
docs/source/markdown/podman-build.1.md
View File

@ -438,9 +438,9 @@ When the option is specified or set to "true", pull the image from the first
registry it is found in as listed in registries.conf. Raise an error if not registry it is found in as listed in registries.conf. Raise an error if not
found in the registries, even if the image is present locally. found in the registries, even if the image is present locally.
If the option is disabled (with *--pull=false*), or not specified, pull the If the option is disabled (with *--pull=false*) or not specified, pull the
image from the registry only if the image is not present locally. Raise an image from the registry only if the image is not present locally. Raise an
error if the image is not found in the registries. error if the image is not found in the registries and is not present locally.
#### **--pull-always** #### **--pull-always**