update golangci-lint to 1.58

disable linters:
- mnd (magic number checker): it seems to complain about almost
  anything, while there might be a few valid findings most of them are
  useless
- canonicalheader: HTTP header syntax, most of the header are given by
  docker and are stable so we cannot change them anyway
- execinquery: it has been deprecated

goerr113 was renamed to err113

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This commit is contained in:
Paul Holzinger
2024-05-06 15:44:53 +02:00
parent 7462fdb406
commit 6bdebea8ae
2 changed files with 5 additions and 2 deletions

View File

@ -20,7 +20,7 @@ linters:
- dupword # too many false positives (e.g., in tests)
- gocognit
- testpackage
- goerr113
- err113
- exhaustivestruct
- errorlint
- wrapcheck
@ -50,10 +50,12 @@ linters:
- gosec
- maligned
- musttag # way to many warnings to fix for now, also some false positives
- mnd # way to many false positives
- gomoddirectives
- containedctx
- contextcheck
- cyclop
- canonicalheader # our current header values are fixed and should not be changed
- errname
- forcetypeassert
- ireturn
@ -69,6 +71,7 @@ linters:
- deadcode # deprecated since v1.49.0, replaced by unused
- structcheck # deprecated since v1.49.0, replaced by unused
- varcheck # deprecated since v1.49.0, replaced by unused
- execinquery
linters-settings:
errcheck:
check-blank: false

View File

@ -62,7 +62,7 @@ BUILDTAGS += ${EXTRA_BUILDTAGS}
# N/B: This value is managed by Renovate, manual changes are
# possible, as long as they don't disturb the formatting
# (i.e. DO NOT ADD A 'v' prefix!)
GOLANGCI_LINT_VERSION := 1.57.2
GOLANGCI_LINT_VERSION := 1.58.0
PYTHON ?= $(shell command -v python3 python|head -n1)
PKG_MANAGER ?= $(shell command -v dnf yum|head -n1)
# ~/.local/bin is not in PATH on all systems