opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-07-03 17:27:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

update golangci-lint to 1.58

Browse Source 
disable linters:
- mnd (magic number checker): it seems to complain about almost
  anything, while there might be a few valid findings most of them are
  useless
- canonicalheader: HTTP header syntax, most of the header are given by
  docker and are stable so we cannot change them anyway
- execinquery: it has been deprecated

goerr113 was renamed to err113

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This commit is contained in:
Paul Holzinger
2024-05-06 15:44:53 +02:00
parent 7462fdb406
commit 6bdebea8ae
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.golangci.yml
View File

@ -20,7 +20,7 @@ linters:
- dupword # too many false positives (e.g., in tests) - dupword # too many false positives (e.g., in tests)
- gocognit - gocognit
- testpackage - testpackage
- goerr113 - err113
- exhaustivestruct - exhaustivestruct
- errorlint - errorlint
- wrapcheck - wrapcheck
@ -50,10 +50,12 @@ linters:
- gosec - gosec
- maligned - maligned
- musttag # way to many warnings to fix for now, also some false positives - musttag # way to many warnings to fix for now, also some false positives
- mnd # way to many false positives
- gomoddirectives - gomoddirectives
- containedctx - containedctx
- contextcheck - contextcheck
- cyclop - cyclop
- canonicalheader # our current header values are fixed and should not be changed
- errname - errname
- forcetypeassert - forcetypeassert
- ireturn - ireturn
@ -69,6 +71,7 @@ linters:
- deadcode # deprecated since v1.49.0, replaced by unused - deadcode # deprecated since v1.49.0, replaced by unused
- structcheck # deprecated since v1.49.0, replaced by unused - structcheck # deprecated since v1.49.0, replaced by unused
- varcheck # deprecated since v1.49.0, replaced by unused - varcheck # deprecated since v1.49.0, replaced by unused
- execinquery
linters-settings: linters-settings:
errcheck: errcheck:
check-blank: false check-blank: false

2
Makefile
View File

@ -62,7 +62,7 @@ BUILDTAGS += ${EXTRA_BUILDTAGS}
# N/B: This value is managed by Renovate, manual changes are # N/B: This value is managed by Renovate, manual changes are
# possible, as long as they don't disturb the formatting # possible, as long as they don't disturb the formatting
# (i.e. DO NOT ADD A 'v' prefix!) # (i.e. DO NOT ADD A 'v' prefix!)
GOLANGCI_LINT_VERSION := 1.57.2 GOLANGCI_LINT_VERSION := 1.58.0
PYTHON ?= $(shell command -v python3 python|head -n1) PYTHON ?= $(shell command -v python3 python|head -n1)
PKG_MANAGER ?= $(shell command -v dnf yum|head -n1) PKG_MANAGER ?= $(shell command -v dnf yum|head -n1)
# ~/.local/bin is not in PATH on all systems # ~/.local/bin is not in PATH on all systems