opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-08-06 19:44:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

varlink: Remove the Ping() method

Browse Source 
There are other ways for developers to "ensure their varlink setup is
working", for example by calling `GetVersion()` or any call on the
org.varlink.service interface.

Signed-off-by: Lars Karlitski <lars@karlitski.net>
This commit is contained in:
Lars Karlitski
2019-02-04 18:18:31 +01:00
parent 10982bcf84
commit 608019b65b
2 changed files with 0 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
cmd/podman/varlink/io.podman.varlink
View File

@ -13,9 +13,6 @@ type Version (
remote_api_version: int remote_api_version: int
) )
type StringResponse (
message: string
)
# ContainerChanges describes the return struct for ListContainerChanges # ContainerChanges describes the return struct for ListContainerChanges
type ContainerChanges ( type ContainerChanges (
changed: []string, changed: []string,
@ -402,18 +399,6 @@ type Runlabel(
opts: [string]string opts: [string]string
) )
# Ping provides a response for developers to ensure their varlink setup is working.
# #### Example
# ~~~
# $ varlink call -m unix:/run/podman/io.podman/io.podman.Ping
# {
# "ping": {
# "message": "OK"
# }
# }
# ~~~
method Ping() -> (ping: StringResponse)
# GetVersion returns a Version structure describing the libpod setup on their # GetVersion returns a Version structure describing the libpod setup on their
# system. # system.
method GetVersion() -> (version: Version) method GetVersion() -> (version: Version)

8
pkg/varlinkapi/system.go
View File

@ -25,14 +25,6 @@ func (i *LibpodAPI) GetVersion(call iopodman.VarlinkCall) error {
}) })
} }
// Ping returns a simple string "OK" response for clients to make sure
// the service is working.
func (i *LibpodAPI) Ping(call iopodman.VarlinkCall) error {
return call.ReplyPing(iopodman.StringResponse{
Message: "OK",
})
}
// GetInfo returns details about the podman host and its stores // GetInfo returns details about the podman host and its stores
func (i *LibpodAPI) GetInfo(call iopodman.VarlinkCall) error { func (i *LibpodAPI) GetInfo(call iopodman.VarlinkCall) error {
versionInfo, err := libpod.GetVersion() versionInfo, err := libpod.GetVersion()