Display correct value for unlimited ulimit

When doing a container inspect on a container with unlimited ulimits,
the value should be -1.  But because the OCI spec requires the ulimit
value to be uint64, we were displaying the inspect values as a uint64 as
well.  Simple change to display as an int64.

Fixes: #9303

Signed-off-by: baude <bbaude@redhat.com>
This commit is contained in:
baude
2021-02-10 13:39:09 -06:00
parent 4d604c1089
commit 5ccb1596b4
3 changed files with 28 additions and 4 deletions

View File

@ -466,4 +466,28 @@ var _ = Describe("Podman inspect", func() {
Expect(len(inspect)).To(Equal(1))
Expect(len(inspect[0].NetworkSettings.Networks)).To(Equal(1))
})
It("Container inspect with unlimited uilimits should be -1", func() {
ctrName := "testctr"
session := podmanTest.Podman([]string{"run", "-d", "--ulimit", "core=-1:-1", "--name", ctrName, ALPINE, "top"})
session.WaitWithDefaultTimeout()
Expect(session.ExitCode()).To(BeZero())
inspect := podmanTest.Podman([]string{"inspect", ctrName})
inspect.WaitWithDefaultTimeout()
Expect(inspect.ExitCode()).To(BeZero())
data := inspect.InspectContainerToJSON()
ulimits := data[0].HostConfig.Ulimits
Expect(len(ulimits)).To(BeNumerically(">", 0))
found := false
for _, ulimit := range ulimits {
if ulimit.Name == "RLIMIT_CORE" {
found = true
Expect(ulimit.Soft).To(BeNumerically("==", -1))
Expect(ulimit.Hard).To(BeNumerically("==", -1))
}
}
Expect(found).To(BeTrue())
})
})