opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-06-24 03:08:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

get runtime for podman-remote push earlier

Browse Source 
to prevent client side panics, we should get the runtime earlier in the
process of push.

Fixes: #4013

Signed-off-by: baude <bbaude@redhat.com>
This commit is contained in:
baude
2019-09-13 10:00:49 -05:00
parent 20772182e6
commit 5539a2a228
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
cmd/podman/push.go
View File

@ -86,6 +86,12 @@ func pushCmd(c *cliconfig.PushValues) error {
destName = args[1]
}
runtime, err := adapter.GetRuntime(getContext(), &c.PodmanCommand)
if err != nil {
return errors.Wrapf(err, "could not create runtime")
}
defer runtime.DeferredShutdown(false)
// --compress and --format can only be used for the "dir" transport
splitArg := strings.SplitN(destName, ":", 2)
if c.Flag("compress").Changed || c.Flag("format").Changed {
@ -106,12 +112,6 @@ func pushCmd(c *cliconfig.PushValues) error {
registryCreds = creds
}
runtime, err := adapter.GetRuntime(getContext(), &c.PodmanCommand)
if err != nil {
return errors.Wrapf(err, "could not create runtime")
}
defer runtime.DeferredShutdown(false)
var writer io.Writer
if !c.Quiet {
writer = os.Stderr