mirror of
https://github.com/containers/podman.git
synced 2025-08-06 03:19:52 +08:00
enable gocritic linter
The linter ensures a common code style. - use switch/case instead of else if - use if instead of switch/case for single case statement - add space between comment and text - detect the use of defer with os.Exit() - use short form var += "..." instead of var = var + "..." - detect problems with append() ``` newSlice := append(orgSlice, val) ``` This could lead to nasty bugs because the orgSlice will be changed in place if it has enough capacity too hold the new elements. Thus we newSlice might not be a copy. Of course most of the changes are just cosmetic and do not cause any logic errors but I think it is a good idea to enforce a common style. This should help maintainability. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This commit is contained in:
@ -122,19 +122,19 @@ func (s *SpecGenerator) Validate() error {
|
||||
}
|
||||
|
||||
// TODO the specgen does not appear to handle this? Should it
|
||||
//switch config.Cgroup.Cgroups {
|
||||
//case "disabled":
|
||||
// switch config.Cgroup.Cgroups {
|
||||
// case "disabled":
|
||||
// if addedResources {
|
||||
// return errors.New("cannot specify resource limits when cgroups are disabled is specified")
|
||||
// }
|
||||
// configSpec.Linux.Resources = &spec.LinuxResources{}
|
||||
//case "enabled", "no-conmon", "":
|
||||
// case "enabled", "no-conmon", "":
|
||||
// // Do nothing
|
||||
//default:
|
||||
// default:
|
||||
// return errors.New("unrecognized option for cgroups; supported are 'default', 'disabled', 'no-conmon'")
|
||||
//}
|
||||
// }
|
||||
invalidUlimitFormatError := errors.New("invalid default ulimit definition must be form of type=soft:hard")
|
||||
//set ulimits if not rootless
|
||||
// set ulimits if not rootless
|
||||
if len(s.ContainerResourceConfig.Rlimits) < 1 && !rootless.IsRootless() {
|
||||
// Containers common defines this as something like nproc=4194304:4194304
|
||||
tmpnproc := containerConfig.Ulimits()
|
||||
|
Reference in New Issue
Block a user