mirror of
https://github.com/containers/podman.git
synced 2025-11-29 17:48:05 +08:00
enable gocritic linter
The linter ensures a common code style. - use switch/case instead of else if - use if instead of switch/case for single case statement - add space between comment and text - detect the use of defer with os.Exit() - use short form var += "..." instead of var = var + "..." - detect problems with append() ``` newSlice := append(orgSlice, val) ``` This could lead to nasty bugs because the orgSlice will be changed in place if it has enough capacity too hold the new elements. Thus we newSlice might not be a copy. Of course most of the changes are just cosmetic and do not cause any logic errors but I think it is a good idea to enforce a common style. This should help maintainability. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This commit is contained in:
@@ -385,7 +385,7 @@ type ContainerInitReport struct {
|
||||
Id string //nolint
|
||||
}
|
||||
|
||||
//ContainerMountOptions describes the input values for mounting containers
|
||||
// ContainerMountOptions describes the input values for mounting containers
|
||||
// in the CLI
|
||||
type ContainerMountOptions struct {
|
||||
All bool
|
||||
|
||||
Reference in New Issue
Block a user