From 5040c6e390e68acce49c56ea595aed833629b750 Mon Sep 17 00:00:00 2001 From: Paul Holzinger Date: Thu, 25 Apr 2024 17:55:53 +0200 Subject: [PATCH] Makefile: remove useless HACK variable in e2e test This doesn't do anything and I was unable to find anything in the git history when or why it was added. The HACK var is just adding another directory to the ginkgo argument list. As the only arg used was the "./hack" dir which does not contain any go files it does nothing besides confusing me about its purpose. Signed-off-by: Paul Holzinger --- Makefile | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index b6fc224aac..68fe91635b 100644 --- a/Makefile +++ b/Makefile @@ -625,15 +625,15 @@ ginkgo-run: .install.ginkgo $(GINKGO) -vv $(TESTFLAGS) --tags "$(TAGS) remote" $(GINKGOTIMEOUT) --flake-attempts $(GINKGO_FLAKE_ATTEMPTS) \ --trace $(if $(findstring y,$(GINKGO_NO_COLOR)),--no-color,) \ $(GINKGO_JSON) $(if $(findstring y,$(GINKGO_PARALLEL)),-p,) $(if $(FOCUS),--focus "$(FOCUS)",) \ - $(if $(FOCUS_FILE),--focus-file "$(FOCUS_FILE)",) $(GINKGOWHAT) $(HACK) + $(if $(FOCUS_FILE),--focus-file "$(FOCUS_FILE)",) $(GINKGOWHAT) .PHONY: ginkgo ginkgo: - $(MAKE) ginkgo-run TAGS="$(BUILDTAGS)" HACK=hack/. + $(MAKE) ginkgo-run TAGS="$(BUILDTAGS)" .PHONY: ginkgo-remote ginkgo-remote: - $(MAKE) ginkgo-run TAGS="$(REMOTETAGS) remote_testing" HACK= + $(MAKE) ginkgo-run TAGS="$(REMOTETAGS) remote_testing" .PHONY: testbindings testbindings: .install.ginkgo @@ -649,7 +649,7 @@ remoteintegration: test-binaries ginkgo-remote localmachine: # gitCommit needed by logformatter, to link to sources @echo /define.gitCommit=$(GIT_COMMIT) - $(MAKE) ginkgo-run GINKGO_PARALLEL=n TAGS="$(REMOTETAGS)" GINKGO_FLAKE_ATTEMPTS=0 FOCUS_FILE=$(FOCUS_FILE) GINKGOWHAT=pkg/machine/e2e/. HACK= + $(MAKE) ginkgo-run GINKGO_PARALLEL=n TAGS="$(REMOTETAGS)" GINKGO_FLAKE_ATTEMPTS=0 FOCUS_FILE=$(FOCUS_FILE) GINKGOWHAT=pkg/machine/e2e/. .PHONY: localsystem localsystem: