opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-06-24 03:08:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #20582 from flouthoc/remove-symlink-from-repo

Browse Source 
remote,test: remove `.dockerignore` which is a symlink
This commit is contained in:
openshift-ci[bot]
2023-11-03 17:17:27 +00:00
committed by GitHub
parent 127505dda9 607aff55fa
commit 4953f7f496
2 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
test/e2e/build/containerignore-symlink/.dockerignore
View File

@ -1 +0,0 @@
/tmp/private_file

14
test/e2e/build_test.go
View File

@ -441,13 +441,25 @@ RUN find /test`, CITEST_IMAGE)
It("podman remote build must not allow symlink for ignore files", func() {
// Create a random file where symlink must be resolved
// but build should not be able to access it.
f, err := os.Create(filepath.Join("/tmp", "private_file"))
privateFile := filepath.Join("/tmp", "private_file")
f, err := os.Create(privateFile)
Expect(err).ToNot(HaveOccurred())
// Mark hello to be ignored in outerfile, but it should not be ignored.
_, err = f.WriteString("hello\n")
Expect(err).ToNot(HaveOccurred())
defer f.Close()
// Create .dockerignore which is a symlink to /tmp/private_file.
currentDir, err := os.Getwd()
Expect(err).ToNot(HaveOccurred())
ignoreFile := filepath.Join(currentDir, "build/containerignore-symlink/.dockerignore")
err = os.Symlink(privateFile, ignoreFile)
Expect(err).ToNot(HaveOccurred())
// Remove created .dockerignore for this test when test ends.
defer func() {
os.Remove(ignoreFile)
}()
if IsRemote() {
podmanTest.StopRemoteService()
podmanTest.StartRemoteService()