opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-08-06 19:44:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

[v5.2] golangci-lint: remove most skip dirs

Browse Source 
Now that we have propert !remote tags set everywhere we can just rely on
that and do not need to skip any dirs.
Also on linux do not lint three times, one remote run is enough.
We still have to skip the test dir for windows/macos though or we need
to add linux build tags there everywhere as well. This seems simpler.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
This commit is contained in:
Paul Holzinger
2024-08-15 13:22:59 +02:00
committed by tomsweeneyredhat
parent 35290c9b32
commit 462c1c6d8e
4 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
hack/golangci-lint.sh
View File

@ -18,11 +18,11 @@ BUILD_TAGS_TUNNEL="$BUILD_TAGS_DEFAULT,remote"
BUILD_TAGS_REMOTE="remote,containers_image_openpgp" BUILD_TAGS_REMOTE="remote,containers_image_openpgp"
SKIP_DIRS_ABI="" SKIP_DIRS_ABI=""
SKIP_DIRS_TUNNEL="pkg/api,pkg/domain/infra/abi,internal/domain/infra/abi" SKIP_DIRS_TUNNEL=""
SKIP_DIRS_REMOTE="libpod/events,pkg/api,pkg/domain/infra/abi,internal/domain/infra/abi,pkg/machine/qemu,pkg/trust,test" SKIP_DIRS_REMOTE="libpod/events,test"
declare -a to_lint declare -a to_lint
to_lint=(ABI TUNNEL REMOTE) to_lint=(ABI TUNNEL)
# Special-case, for Darwin and Windows only "remote" linting is possible and required. # Special-case, for Darwin and Windows only "remote" linting is possible and required.
if [[ "$GOOS" == "windows" ]] || [[ "$GOOS" == "darwin" ]]; then if [[ "$GOOS" == "windows" ]] || [[ "$GOOS" == "darwin" ]]; then

2
libpod/events/logfile_test.go
View File

@ -1,3 +1,5 @@
//go:build linux || freebsd
package events package events
import ( import (

2
pkg/bindings/test/resource_test.go
View File

@ -1,3 +1,5 @@
//go:build linux
package bindings_test package bindings_test
import ( import (

2
test/e2e/run_networking_test.go
View File

@ -1,3 +1,5 @@
//go:build linux
package integration package integration
import ( import (