From aeff58e0b8eae6e7a89de190af200dd5bee19364 Mon Sep 17 00:00:00 2001 From: Chris Evich Date: Wed, 21 Jun 2023 14:54:16 -0400 Subject: [PATCH] [CI:BUILD] Help Renovate manage the golangci-lint version It's a bit cumbersome to manage a tooling version buried deep in a command, let alone one also buried deep in a `Makefile`. Add a variable to hold the version number so renovate can easily manage it. This happens via a `regex` manager in the shared configuration include `containers/automation//renovate/defaults.json5`. Also add a helpful note/reminder to humans who may want to manually change the version for some reason. Depends on: https://github.com/containers/automation/pull/145 Signed-off-by: Chris Evich --- Makefile | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 53f0365dc3..cc173f1a04 100644 --- a/Makefile +++ b/Makefile @@ -57,6 +57,10 @@ BUILDTAGS ?= \ $(shell hack/libsubid_tag.sh) \ exclude_graphdriver_devicemapper \ seccomp +# N/B: This value is managed by Renovate, manual changes are +# possible, as long as they don't disturb the formatting +# (i.e. DO NOT ADD A 'v' prefix!) +GOLANGCI_LINT_VERSION := 1.53.3 PYTHON ?= $(shell command -v python3 python|head -n1) PKG_MANAGER ?= $(shell command -v dnf yum|head -n1) # ~/.local/bin is not in PATH on all systems @@ -941,7 +945,7 @@ install.tools: .install.golangci-lint ## Install needed tools .PHONY: .install.golangci-lint .install.golangci-lint: - VERSION=1.53.3 ./hack/install_golangci.sh + VERSION=$(GOLANGCI_LINT_VERSION) ./hack/install_golangci.sh .PHONY: .install.swagger .install.swagger: