From 3f87f0765d7626b053cd41a55927c81790e3eee3 Mon Sep 17 00:00:00 2001 From: Paul Holzinger Date: Fri, 7 Nov 2025 18:04:26 +0100 Subject: [PATCH] hack/bats: port it to use the new remote support The system tests can setup their own server now so just use that and don't require the user to spawn its own. Signed-off-by: Paul Holzinger --- hack/bats | 20 ++------------------ 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/hack/bats b/hack/bats index e416f82d15..505b890440 100755 --- a/hack/bats +++ b/hack/bats @@ -12,7 +12,7 @@ $0 is a wrapper for invoking podman system tests. --root Run only as root --rootless Run only as user (i.e. you) - --remote Run with podman-remote (see below) + --remote Run with podman-remote FILENAME-PATTERN Run only test files that match 'test/system/*name*', e.g. '500' or 'net' will match 500-networking.bats. @@ -36,16 +36,6 @@ By default, tests ./bin/podman. To test a different podman, do: \$ env PODMAN=/abs/path/to/podman $0 .... -To test podman-remote, start your own servers (root and rootless) via: - - \$ bin/podman system service --timeout=0 & - \$ sudo !! - -...then invoke this script with --remote. (This script can't start the -servers, because we can sudo *starting* the service but can't sudo -stopping it: by the time the bats tests finish, the sudo timeout will -have expired. We apologize for the inconvenience.) - Examples: \$ $0 220:\"restart cleans up\" @@ -113,13 +103,7 @@ if [[ "$REMOTE" ]]; then if ! [[ $PODMAN =~ -remote ]]; then PODMAN=${PODMAN}-remote fi - - if [[ -n "$TEST_ROOT" ]]; then - sudo $PODMAN info >/dev/null || exit 1 - fi - if [[ -n "$TEST_ROOTLESS" ]]; then - $PODMAN info >/dev/null || exit 1 - fi + export REMOTESYSTEM_TRANSPORT=unix fi # END initialization and command-line arg checking