opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-10-17 11:14:40 +08:00
Code Issues Packages Projects Releases Wiki Activity

export: use io.Writer instead of file

Browse Source 
This allows use to use STDOUT directly without having to call open
again, also this makes the export API endpoint much more performant
since it no longer needs to copy to a temp file.
I noticed that there was no export API test so I added one.

And lastly opening /dev/stdout will not work on windows.

Fixes #16870

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This commit is contained in:
Paul Holzinger
2022-12-19 19:45:06 +01:00
parent 56982a9236
commit 3ac5d10098
7 changed files with 37 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
libpod/container_api.go
View File

@ -462,7 +462,7 @@ func (c *Container) Unpause() error {
// Export exports a container's root filesystem as a tar archive
// The archive will be saved as a file at the given path
func (c *Container) Export(path string) error {
func (c *Container) Export(out io.Writer) error {
if !c.batched {
c.lock.Lock()
defer c.lock.Unlock()
@ -477,7 +477,7 @@ func (c *Container) Export(path string) error {
}
defer c.newContainerEvent(events.Mount)
return c.export(path)
return c.export(out)
}
// AddArtifact creates and writes to an artifact file for the container