Throw error on invalid sort value

We define the valid sort values, so we should throw an error
on invalid sort values.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
This commit is contained in:
Daniel J Walsh
2020-01-26 06:32:31 +01:00
parent bb7f72bbd6
commit 38d2ef0cbd
2 changed files with 36 additions and 11 deletions

View File

@@ -159,6 +159,21 @@ func imagesCmd(c *cliconfig.ImagesValues) error {
filters = append(filters, fmt.Sprintf("reference=%s", image))
}
var sortValues = map[string]bool{
"created": true,
"id": true,
"repository": true,
"size": true,
"tag": true,
}
if !sortValues[c.Sort] {
keys := make([]string, 0, len(sortValues))
for k := range sortValues {
keys = append(keys, k)
}
return errors.Errorf("invalid sort value %q, required values: %s", c.Sort, strings.Join(keys, ", "))
}
opts := imagesOptions{
quiet: c.Quiet,
noHeading: c.Noheading,