opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-06-28 22:53:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix podman-remote run --attach stdin to show container ID

Browse Source 
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
This commit is contained in:
Boaz Shuster
2022-09-16 10:52:58 +03:00
parent 750726e62c
commit 377773ab5b
2 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/domain/infra/tunnel/containers.go
View File

@ -620,6 +620,9 @@ func (ic *ContainerEngine) ContainerExecDetached(ctx context.Context, nameOrID s
} }
func startAndAttach(ic *ContainerEngine, name string, detachKeys *string, input, output, errput *os.File) error { func startAndAttach(ic *ContainerEngine, name string, detachKeys *string, input, output, errput *os.File) error {
if output == nil && errput == nil {
fmt.Printf("%s\n", name)
}
attachErr := make(chan error) attachErr := make(chan error)
attachReady := make(chan bool) attachReady := make(chan bool)
options := new(containers.AttachOptions).WithStream(true) options := new(containers.AttachOptions).WithStream(true)

10
test/system/030-run.bats
View File

@ -892,4 +892,14 @@ $IMAGE--c_ok" \
run_podman container rm -f -t 0 c_ok c_fail_no_rm run_podman container rm -f -t 0 c_ok c_fail_no_rm
} }
@test "podman run --attach stdin prints container ID" {
ctr_name="container-$(random_string 5)"
run_podman run --name $ctr_name --attach stdin $IMAGE echo hello
run_output=$output
run_podman inspect --format "{{.Id}}" $ctr_name
ctr_id=$output
is "$run_output" "$ctr_id" "Did not find container ID in the output"
run_podman rm $ctr_name
}
# vim: filetype=sh # vim: filetype=sh