mirror of
https://github.com/containers/podman.git
synced 2025-12-11 17:27:19 +08:00
Only allocate tty when -t
In our ezrly development, we always allocated a tty when not -d. Now we should only allocated when the user asks for it. Resolves: #573 Signed-off-by: baude <bbaude@redhat.com> Closes: #574 Approved by: rhatdan
This commit is contained in:
@@ -447,13 +447,7 @@ func parseCreateOpts(c *cli.Context, runtime *libpod.Runtime, imageName string,
|
||||
return nil, err
|
||||
}
|
||||
|
||||
// Because we cannot do a non-terminal attach, we need to set tty to true
|
||||
// if detach is not false
|
||||
// TODO Allow non-terminal attach
|
||||
tty := c.Bool("tty")
|
||||
if !c.Bool("detach") && !tty {
|
||||
tty = true
|
||||
}
|
||||
|
||||
pidMode := container.PidMode(c.String("pid"))
|
||||
if !pidMode.Valid() {
|
||||
|
||||
Reference in New Issue
Block a user