opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-06-25 20:26:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

Don't require engine connection for farm

Browse Source 
Don't require the need to connect to an engine/podman
machine when doing the farm create, ls, rm, and update
commands.
Connection to the engine is required for the farm build
command.

[NO NEW TESTS NEEDED]

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
This commit is contained in:
Urvashi Mohnani
2024-01-29 11:22:51 -05:00
parent 2ba3605108
commit 3136f0fca0
4 changed files with 36 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
cmd/podman/farm/create.go
View File

@ -6,6 +6,7 @@ import (
"github.com/containers/common/pkg/completion" "github.com/containers/common/pkg/completion"
"github.com/containers/common/pkg/config" "github.com/containers/common/pkg/config"
"github.com/containers/podman/v4/cmd/podman/registry" "github.com/containers/podman/v4/cmd/podman/registry"
"github.com/containers/podman/v4/cmd/podman/validate"
"github.com/spf13/cobra" "github.com/spf13/cobra"
"golang.org/x/exp/slices" "golang.org/x/exp/slices"
) )
@ -20,7 +21,9 @@ var (
Args: cobra.MinimumNArgs(1), Args: cobra.MinimumNArgs(1),
Short: "Create a new farm", Short: "Create a new farm",
Long: farmCreateDescription, Long: farmCreateDescription,
PersistentPreRunE: validate.NoOp,
RunE: create, RunE: create,
PersistentPostRunE: validate.NoOp,
ValidArgsFunction: completion.AutocompleteNone, ValidArgsFunction: completion.AutocompleteNone,
Example: `podman farm create myfarm connection1 Example: `podman farm create myfarm connection1
podman farm create myfarm`, podman farm create myfarm`,

2
cmd/podman/farm/list.go
View File

@ -25,7 +25,9 @@ and the output format can be changed to JSON or a user specified Go template.`
Args: validate.NoArgs, Args: validate.NoArgs,
Short: "List all existing farms", Short: "List all existing farms",
Long: farmLsDescription, Long: farmLsDescription,
PersistentPreRunE: validate.NoOp,
RunE: list, RunE: list,
PersistentPostRunE: validate.NoOp,
ValidArgsFunction: completion.AutocompleteNone, ValidArgsFunction: completion.AutocompleteNone,
} }

3
cmd/podman/farm/remove.go
View File

@ -7,6 +7,7 @@ import (
"github.com/containers/common/pkg/config" "github.com/containers/common/pkg/config"
"github.com/containers/podman/v4/cmd/podman/common" "github.com/containers/podman/v4/cmd/podman/common"
"github.com/containers/podman/v4/cmd/podman/registry" "github.com/containers/podman/v4/cmd/podman/registry"
"github.com/containers/podman/v4/cmd/podman/validate"
"github.com/sirupsen/logrus" "github.com/sirupsen/logrus"
"github.com/spf13/cobra" "github.com/spf13/cobra"
) )
@ -18,7 +19,9 @@ var (
Aliases: []string{"rm"}, Aliases: []string{"rm"},
Short: "Remove one or more farms", Short: "Remove one or more farms",
Long: farmRmDescription, Long: farmRmDescription,
PersistentPreRunE: validate.NoOp,
RunE: rm, RunE: rm,
PersistentPostRunE: validate.NoOp,
ValidArgsFunction: common.AutoCompleteFarms, ValidArgsFunction: common.AutoCompleteFarms,
Example: `podman farm rm myfarm1 myfarm2 Example: `podman farm rm myfarm1 myfarm2
podman farm rm --all`, podman farm rm --all`,

3
cmd/podman/farm/update.go
View File

@ -8,6 +8,7 @@ import (
"github.com/containers/common/pkg/config" "github.com/containers/common/pkg/config"
"github.com/containers/podman/v4/cmd/podman/common" "github.com/containers/podman/v4/cmd/podman/common"
"github.com/containers/podman/v4/cmd/podman/registry" "github.com/containers/podman/v4/cmd/podman/registry"
"github.com/containers/podman/v4/cmd/podman/validate"
"github.com/spf13/cobra" "github.com/spf13/cobra"
"golang.org/x/exp/slices" "golang.org/x/exp/slices"
) )
@ -18,7 +19,9 @@ var (
Use: "update [options] FARM", Use: "update [options] FARM",
Short: "Update an existing farm", Short: "Update an existing farm",
Long: farmUpdateDescription, Long: farmUpdateDescription,
PersistentPreRunE: validate.NoOp,
RunE: farmUpdate, RunE: farmUpdate,
PersistentPostRunE: validate.NoOp,
Args: cobra.ExactArgs(1), Args: cobra.ExactArgs(1),
ValidArgsFunction: common.AutoCompleteFarms, ValidArgsFunction: common.AutoCompleteFarms,
Example: `podman farm update --add con1 farm1 Example: `podman farm update --add con1 farm1