opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-06-27 05:26:50 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix handling of CheckRootlessUIDRange

Browse Source 
If I have multiple ranges of UIDs specified in the /etc/subuid, this check
blows up and incorrectly blocks the use of --user flag.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
This commit is contained in:
Daniel J Walsh
2020-10-05 08:34:48 -04:00
parent caace52d54
commit 30bd8ed506
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
pkg/util/utils_linux.go
View File

@ -60,11 +60,12 @@ func CheckRootlessUIDRange(uid int) error {
if err != nil { if err != nil {
return err return err
} }
total := 0
for _, u := range uids { for _, u := range uids {
// add 1 since we also map in the user's own UID total += u.Size
if uid > u.Size+1 {
return errors.Errorf("requested user's UID %d is too large for the rootless user namespace", uid)
} }
if uid > total {
return errors.Errorf("requested user's UID %d is too large for the rootless user namespace", uid)
} }
return nil return nil
} }