opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-06-22 09:58:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

specgen: do not always set shmsize

Browse Source 
if it wasn't overriden on the CLI, leave it undefined.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
This commit is contained in:
Giuseppe Scrivano
2020-04-22 12:37:25 +02:00
parent d98b6f4232
commit 2fd6a84c09
3 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
cmd/podman/common/create.go
View File

@ -394,8 +394,9 @@ func GetCreateFlags(cf *ContainerCLIOpts) *pflag.FlagSet {
"security-opt", containerConfig.SecurityOptions(), "security-opt", containerConfig.SecurityOptions(),
"Security Options", "Security Options",
) )
shmSize := ""
createFlags.StringVar( createFlags.StringVar(
&cf.ShmSize, &shmSize,
"shm-size", containerConfig.ShmSize(), "shm-size", containerConfig.ShmSize(),
"Size of /dev/shm "+sizeWithUnitFormat, "Size of /dev/shm "+sizeWithUnitFormat,
) )

10
cmd/podman/common/specgen.go
View File

@ -403,11 +403,13 @@ func FillOutSpecGen(s *specgen.SpecGenerator, c *ContainerCLIOpts, args []string
} }
// SHM Size // SHM Size
shmSize, err := units.FromHumanSize(c.ShmSize) if c.ShmSize != "" {
if err != nil { shmSize, err := units.FromHumanSize(c.ShmSize)
return errors.Wrapf(err, "unable to translate --shm-size") if err != nil {
return errors.Wrapf(err, "unable to translate --shm-size")
}
s.ShmSize = &shmSize
} }
s.ShmSize = &shmSize
s.HostAdd = c.Net.AddHosts s.HostAdd = c.Net.AddHosts
s.UseImageResolvConf = c.Net.UseImageResolvConf s.UseImageResolvConf = c.Net.UseImageResolvConf
s.DNSServers = c.Net.DNSServers s.DNSServers = c.Net.DNSServers

4
cmd/podman/containers/create.go
View File

@ -131,6 +131,10 @@ func createInit(c *cobra.Command) error {
logrus.Warn("setting security options with --privileged has no effect") logrus.Warn("setting security options with --privileged has no effect")
} }
if c.Flag("shm-size").Changed {
cliVals.ShmSize = c.Flag("shm-size").Value.String()
}
if (c.Flag("dns").Changed || c.Flag("dns-opt").Changed || c.Flag("dns-search").Changed) && (cliVals.Net.Network.NSMode == specgen.NoNetwork || cliVals.Net.Network.IsContainer()) { if (c.Flag("dns").Changed || c.Flag("dns-opt").Changed || c.Flag("dns-search").Changed) && (cliVals.Net.Network.NSMode == specgen.NoNetwork || cliVals.Net.Network.IsContainer()) {
return errors.Errorf("conflicting options: dns and the network mode.") return errors.Errorf("conflicting options: dns and the network mode.")
} }