opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-09-11 09:05:23 +08:00
Code Issues Packages Projects Releases Wiki Activity

simplify bindings generation

Browse Source 
Run `go generate ./pkg/bindings/...` once for all bindings instead of
generating them separately.  This should speed up bindings generation
as a given package is visited only once, and it fixes #8989 by dropping
the use of pushd and popd.

Fixes: #8989
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
This commit is contained in:
Valentin Rothberg
2021-01-17 16:37:55 +01:00
parent 4629942686
commit 2df59829e4
1 changed files with 1 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
Makefile
View File

@ -462,15 +462,7 @@ podman-remote-%-release:
BINDINGS_SOURCE = $(wildcard pkg/bindings/**/types.go) BINDINGS_SOURCE = $(wildcard pkg/bindings/**/types.go)
.generate-bindings: $(BINDINGS_SOURCE) .generate-bindings: $(BINDINGS_SOURCE)
ifneq ($(shell uname -s), Darwin) ifneq ($(shell uname -s), Darwin)
for i in $(BINDINGS_SOURCE); do \ $(GO) generate -mod=vendor ./pkg/bindings/... ;
dirname=$$(dirname $${i}); \
shortname=$$(basename $${dirname}); \
pushd $${dirname}>/dev/null; \
echo $${dirname}; \
echo $(GO) generate; \
$(GO) generate -mod=vendor; \
popd > /dev/null; \
done;
endif endif
touch .generate-bindings touch .generate-bindings