opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-06-24 03:08:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

test/e2e/save_test.go: fix flake

Browse Source 
Save at most three images and sort them by size.  The test started to
flake as _all_ local images were saved which is not neccessary.

Fixes: #14468
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
This commit is contained in:
Valentin Rothberg
2022-06-03 11:38:21 +02:00
parent f7a54088c3
commit 2b0cb30026
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
test/e2e/save_test.go
View File

@ -226,13 +226,17 @@ default-docker:
}) })
It("podman save --multi-image-archive (untagged images)", func() { It("podman save --multi-image-archive (untagged images)", func() {
// Refer to images via ID instead of tag. // #14468: to make execution time more predictable, save at
session := podmanTest.Podman([]string{"images", "--format", "{{.ID}}"}) // most three images and sort them by size.
session := podmanTest.Podman([]string{"images", "--sort", "size", "--format", "{{.ID}}"})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(0)) Expect(session).Should(Exit(0))
ids := session.OutputToStringArray() ids := session.OutputToStringArray()
Expect(len(ids)).To(BeNumerically(">", 1), "We need to have *some* images to save") Expect(len(ids)).To(BeNumerically(">", 1), "We need to have *some* images to save")
if len(ids) > 3 {
ids = ids[:3]
}
multiImageSave(podmanTest, ids) multiImageSave(podmanTest, ids)
}) })
}) })