opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-06-19 16:33:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #12606 from vrothberg/fix-12441

Browse Source 
bindings rmi test: clarify behavior
This commit is contained in:
OpenShift Merge Robot
2021-12-16 17:01:50 +01:00
committed by GitHub
parent b9141c06f0 f241efb179
commit 273da42af2
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
pkg/bindings/test/images_test.go
View File

@ -85,14 +85,16 @@ var _ = Describe("Podman images", func() {
// Test to validate the remove image api
It("remove image", func() {
// Remove invalid image should be a 404
// NOTE that removing an image that does not exist will still
// return a 200 http status. The response, however, includes
// the exit code that podman-remote should exit with.
//
// The libpod/images/remove endpoint supports batch removal of
// images for performance reasons and for hiding the logic of
// deciding which exit code to use from the client.
response, errs := images.Remove(bt.conn, []string{"foobar5000"}, nil)
Expect(len(errs)).To(BeNumerically(">", 0))
code, _ := bindings.CheckResponseCode(errs[0])
// FIXME FIXME FIXME: #12441: THIS IS BROKEN
// FIXME FIXME FIXME: we get msg: "foobar5000: image not known"
// FIXME FIXME FIXME: ...with no ResponseCode
Expect(code).To(BeNumerically("==", -1))
Expect(response.ExitCode).To(BeNumerically("==", 1)) // podman-remote would exit with 1
// Remove an image by name, validate image is removed and error is nil
inspectData, err := images.GetImage(bt.conn, busybox.shortName, nil)
@ -102,7 +104,7 @@ var _ = Describe("Podman images", func() {
Expect(inspectData.ID).To(Equal(response.Deleted[0]))
inspectData, err = images.GetImage(bt.conn, busybox.shortName, nil)
code, _ = bindings.CheckResponseCode(err)
code, _ := bindings.CheckResponseCode(err)
Expect(code).To(BeNumerically("==", http.StatusNotFound))
// Start a container with alpine image