From 23c5890f25b8fed74ad0809993e4c6a100bed158 Mon Sep 17 00:00:00 2001 From: binghongtao <695097494plus@gmail.com> Date: Sun, 6 Aug 2023 22:38:08 +0800 Subject: [PATCH] remove temporary files when copy [NO NEW TESTS NEEDED] Fixes: #19496 Signed-off-by: binghongtao <695097494plus@gmail.com> --- cmd/podman/containers/cp.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cmd/podman/containers/cp.go b/cmd/podman/containers/cp.go index 5231066a2e..faeb7bd96e 100644 --- a/cmd/podman/containers/cp.go +++ b/cmd/podman/containers/cp.go @@ -382,6 +382,8 @@ func copyToContainer(container string, containerPath string, hostPath string) er if err != nil { return err } + defer os.Remove(tmpFile.Name()) + _, err = io.Copy(tmpFile, os.Stdin) if err != nil { return err @@ -389,6 +391,7 @@ func copyToContainer(container string, containerPath string, hostPath string) er if err = tmpFile.Close(); err != nil { return err } + if !archive.IsArchivePath(tmpFile.Name()) { return errors.New("source must be a (compressed) tar archive when copying from stdin") }