opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-07-15 03:02:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add shell completion tests for secrets

Browse Source 
Add the SECRET keyword to the shell completion test. Also update the
use line for podman secret create to use `NAME` instead of `SECRET`.
This matches the other commands such as network/volume create.

Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
This commit is contained in:
Paul Holzinger
2021-02-10 10:41:51 +01:00
parent 055e2dda3a
commit 1cc387bf78
2 changed files with 22 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/podman/secrets/create.go
View File

@ -16,7 +16,7 @@ import (
var ( var (
createCmd = &cobra.Command{ createCmd = &cobra.Command{
Use: "create [options] SECRET FILE|-", Use: "create [options] NAME FILE|-",
Short: "Create a new secret", Short: "Create a new secret",
Long: "Create a secret. Input can be a path to a file or \"-\" (read from stdin). Default driver is file (unencrypted).", Long: "Create a secret. Input can be a path to a file or \"-\" (read from stdin). Default driver is file (unencrypted).",
RunE: create, RunE: create,

22
test/system/600-completion.bats
View File

@ -157,7 +157,17 @@ function check_shell_completion() {
# resume # resume
;;& ;;&
*PATH* | *CONTEXT* | *KUBEFILE* | *COMMAND* | *ARG...* | *URI*) *SECRET*)
run_completion "$@" $cmd "${extra_args[@]}" ""
is "$output" ".*$random_secret_name${nl}" \
"$* $cmd: actual secret listed in suggestions"
_check_completion_end NoFileComp
match=true
# resume
;;&
*PATH* | *CONTEXT* | *FILE* | *COMMAND* | *ARG...* | *URI*)
# default shell completion should be done for everything which accepts a path # default shell completion should be done for everything which accepts a path
run_completion "$@" $cmd "${extra_args[@]}" "" run_completion "$@" $cmd "${extra_args[@]}" ""
@ -232,6 +242,11 @@ function _check_completion_end() {
random_image_tag=$(random_string 5) random_image_tag=$(random_string 5)
random_network_name=$(random_string 30) random_network_name=$(random_string 30)
random_volume_name=$(random_string 30) random_volume_name=$(random_string 30)
random_secret_name=$(random_string 30)
random_secret_content=$(random_string 30)
secret_file=$PODMAN_TMPDIR/$(random_string 10)
echo $random_secret_content > $secret_file
# create a container for each state since some commands are only suggesting running container for example # create a container for each state since some commands are only suggesting running container for example
run_podman create --name created-$random_container_name $IMAGE run_podman create --name created-$random_container_name $IMAGE
@ -263,6 +278,8 @@ function _check_completion_end() {
# create volume # create volume
run_podman volume create $random_volume_name run_podman volume create $random_volume_name
# create secret
run_podman secret create $random_secret_name $secret_file
# $PODMAN may be a space-separated string, e.g. if we include a --url. # $PODMAN may be a space-separated string, e.g. if we include a --url.
local -a podman_as_array=($PODMAN) local -a podman_as_array=($PODMAN)
@ -274,6 +291,9 @@ function _check_completion_end() {
check_shell_completion check_shell_completion
# cleanup # cleanup
run_podman secret rm $random_secret_name
rm -f $secret_file
run_podman volume rm $random_volume_name run_podman volume rm $random_volume_name
run_podman network rm $random_network_name run_podman network rm $random_network_name