opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-06-27 21:50:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

healthcheck system tests: try to fix flake

Browse Source 
Weird one-off flake seen:

   # ... healthcheck run <containername>
   Error: container SHA is not running

The only way I can see this happening is if the healthcheck
auto-timer triggered, which seems impossible because that
should be 30s and the log timestamps show this test taking
18s. But, shrug, let's see if disabling the timer works. I
don't have high hopes that this will fix anything, but it's
probably a good idea regardless.

Also, since this test loops over different policies, include
policy name in error messages as a courtesy. (It's obtainable
anyway by scrolling up)

Signed-off-by: Ed Santiago <santiago@redhat.com>
This commit is contained in:
Ed Santiago
2022-11-14 12:28:27 -07:00
parent 43cef625b5
commit 1a839a96dc
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
test/system/220-healthcheck.bats
View File

@ -97,6 +97,7 @@ Log[-1].Output | \"Uh-oh on stdout!\\\nUh-oh on stderr!\"
--health-cmd /healthcheck \ --health-cmd /healthcheck \
--health-retries=1 \ --health-retries=1 \
--health-on-failure=$policy \ --health-on-failure=$policy \
--health-interval=disable \
$img $img
# healthcheck should succeed # healthcheck should succeed
@ -107,7 +108,7 @@ Log[-1].Output | \"Uh-oh on stdout!\\\nUh-oh on stderr!\"
# healthcheck should now fail, with exit status 1 and 'unhealthy' output # healthcheck should now fail, with exit status 1 and 'unhealthy' output
run_podman 1 healthcheck run $ctr run_podman 1 healthcheck run $ctr
is "$output" "unhealthy" "output from 'podman healthcheck run'" is "$output" "unhealthy" "output from 'podman healthcheck run' (policy: $policy)"
run_podman inspect $ctr --format "{{.State.Status}} {{.Config.HealthcheckOnFailureAction}}" run_podman inspect $ctr --format "{{.State.Status}} {{.Config.HealthcheckOnFailureAction}}"
if [[ $policy == "restart" ]];then if [[ $policy == "restart" ]];then
@ -118,10 +119,10 @@ Log[-1].Output | \"Uh-oh on stdout!\\\nUh-oh on stderr!\"
# Container is still running and health check still broken # Container is still running and health check still broken
is "$output" "running $policy" "container continued running" is "$output" "running $policy" "container continued running"
run_podman 1 healthcheck run $ctr run_podman 1 healthcheck run $ctr
is "$output" "unhealthy" "output from 'podman healthcheck run'" is "$output" "unhealthy" "output from 'podman healthcheck run' (policy: $policy)"
else else
# kill and stop yield the container into a non-running state # kill and stop yield the container into a non-running state
is "$output" ".* $policy" "container was stopped/killed" is "$output" ".* $policy" "container was stopped/killed (policy: $policy)"
assert "$output" != "running $policy" assert "$output" != "running $policy"
# also make sure that it's not stuck in the stopping state # also make sure that it's not stuck in the stopping state
assert "$output" != "stopping $policy" assert "$output" != "stopping $policy"