opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-06-25 12:20:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use Header.Values in GetCredentials.has

Browse Source 
It's possibly a bit more expensive, but semantically safer
because it does header normalization.

And we'll regain the cost by not looking up the value repeatedly.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This commit is contained in:
Miloslav Trmač
2021-09-11 22:39:25 +02:00
parent 2946e83493
commit 1589d70bcb
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/auth/auth.go
View File

@ -34,8 +34,8 @@ const XRegistryConfigHeader HeaderAuthName = "X-Registry-Config"
// the necessary authentication information for libpod operations // the necessary authentication information for libpod operations
func GetCredentials(r *http.Request) (*types.DockerAuthConfig, string, error) { func GetCredentials(r *http.Request) (*types.DockerAuthConfig, string, error) {
has := func(key HeaderAuthName) bool { has := func(key HeaderAuthName) bool {
hdr, found := r.Header[key.String()] hdr := r.Header.Values(key.String())
return found && len(hdr) > 0 return len(hdr) > 0
} }
switch { switch {
case has(XRegistryConfigHeader): case has(XRegistryConfigHeader):