Merge pull request #2059 from rhatdan/ociruntime

podman build is not using the default oci-runtime
This commit is contained in:
OpenShift Merge Robot
2018-12-28 17:44:35 -08:00
committed by GitHub
2 changed files with 10 additions and 1 deletions

View File

@ -205,6 +205,10 @@ func buildCmd(c *cli.Context) error {
}
namespaceOptions.AddOrReplace(usernsOption...)
ociruntime := runtime.GetOCIRuntimePath()
if c.IsSet("runtime") {
ociruntime = c.String("runtime")
}
options := imagebuildah.BuildOptions{
ContextDirectory: contextDir,
PullPolicy: pullPolicy,
@ -217,7 +221,7 @@ func buildCmd(c *cli.Context) error {
Out: stdout,
Err: stderr,
ReportWriter: reporter,
Runtime: c.String("runtime"),
Runtime: ociruntime,
RuntimeArgs: runtimeFlags,
OutputFormat: format,
SystemContext: systemContext,

View File

@ -180,6 +180,11 @@ func (r *Runtime) GetConmonVersion() (string, error) {
return strings.TrimSuffix(strings.Replace(output, "\n", ", ", 1), "\n"), nil
}
// GetOCIRuntimePath returns the path to the OCI Runtime Path the runtime is using
func (r *Runtime) GetOCIRuntimePath() string {
return r.ociRuntimePath
}
// GetOCIRuntimeVersion returns a string representation of the oci runtimes version
func (r *Runtime) GetOCIRuntimeVersion() (string, error) {
output, err := utils.ExecCmd(r.ociRuntimePath, "--version")