From 03b100563e1488efcb4bd7b4cb968335c1f9f94c Mon Sep 17 00:00:00 2001 From: Brent Baude Date: Mon, 27 Jan 2025 12:43:28 -0600 Subject: [PATCH] Remove unnecessary error handling A function in the reset code does not return an error. Simply removing the error variable and check for the condition (which was always false or nil) Signed-off-by: Brent Baude --- cmd/podman/machine/reset.go | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/cmd/podman/machine/reset.go b/cmd/podman/machine/reset.go index 2d49d8f8cd..bcfb88eabe 100644 --- a/cmd/podman/machine/reset.go +++ b/cmd/podman/machine/reset.go @@ -47,15 +47,8 @@ func init() { } func reset(_ *cobra.Command, _ []string) error { - var ( - err error - ) - - providers := provider2.GetAll() - if err != nil { - return err - } - for _, p := range providers { + allProviders := provider2.GetAll() + for _, p := range allProviders { hasPerms := provider2.HasPermsForProvider(p.VMType()) isInstalled, err := provider2.IsInstalled(p.VMType()) if !hasPerms && (isInstalled || err != nil) && !resetOptions.Force { @@ -65,7 +58,7 @@ func reset(_ *cobra.Command, _ []string) error { } if !resetOptions.Force { - listResponse, err := shim.List(providers, machine.ListOptions{}) + listResponse, err := shim.List(allProviders, machine.ListOptions{}) if err != nil { return err } @@ -82,7 +75,7 @@ func reset(_ *cobra.Command, _ []string) error { return nil } } - return shim.Reset(providers, resetOptions) + return shim.Reset(allProviders, resetOptions) } func resetConfirmationMessage(listResponse []*machine.ListResponse) {