mirror of
https://github.com/containers/podman.git
synced 2025-05-22 17:46:52 +08:00
Fix E2E tests
The Commit test is blatantly wrong and testing buggy behavior. We should be commiting the destination, if anything - and more likely nothing at all. When force-removing volumes, don't remove the volumes of containers we need to remove. This can lead to a chicken and the egg problem where the container removes the volume before we can. When we re-add volume locks this could lead to deadlocks. I don't really want to deal with this, and this doesn't seem a particularly harmful quirk, so we'll let this slide until we get a bug report. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
This commit is contained in:
@ -144,7 +144,7 @@ var _ = Describe("Podman commit", func() {
|
||||
inspect.WaitWithDefaultTimeout()
|
||||
Expect(inspect.ExitCode()).To(Equal(0))
|
||||
image := inspect.InspectImageJSON()
|
||||
_, ok := image[0].Config.Volumes["/tmp"]
|
||||
_, ok := image[0].Config.Volumes["/foo"]
|
||||
Expect(ok).To(BeTrue())
|
||||
|
||||
r := podmanTest.Podman([]string{"run", "newimage"})
|
||||
|
Reference in New Issue
Block a user