mirror of
https://github.com/open-telemetry/opentelemetry-python-contrib.git
synced 2025-07-29 13:12:39 +08:00
9fea7f7a27
SQLAlchemy spans were missing kind field and it was being set to internal instead of client. This commit changes sqlalchemy spans to have kind set to "client" instead.
73 lines
2.9 KiB
Python
73 lines
2.9 KiB
Python
# Copyright The OpenTelemetry Authors
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
from unittest import mock
|
|
|
|
from sqlalchemy import create_engine
|
|
|
|
from opentelemetry import trace
|
|
from opentelemetry.instrumentation.sqlalchemy import SQLAlchemyInstrumentor
|
|
from opentelemetry.test.test_base import TestBase
|
|
|
|
|
|
class TestSqlalchemyInstrumentation(TestBase):
|
|
def tearDown(self):
|
|
super().tearDown()
|
|
SQLAlchemyInstrumentor().uninstrument()
|
|
|
|
def test_trace_integration(self):
|
|
engine = create_engine("sqlite:///:memory:")
|
|
SQLAlchemyInstrumentor().instrument(
|
|
engine=engine, tracer_provider=self.tracer_provider,
|
|
)
|
|
cnx = engine.connect()
|
|
cnx.execute("SELECT 1 + 1;").fetchall()
|
|
spans = self.memory_exporter.get_finished_spans()
|
|
|
|
self.assertEqual(len(spans), 1)
|
|
self.assertEqual(spans[0].name, "SELECT 1 + 1;")
|
|
self.assertEqual(spans[0].kind, trace.SpanKind.CLIENT)
|
|
|
|
def test_not_recording(self):
|
|
mock_tracer = mock.Mock()
|
|
mock_span = mock.Mock()
|
|
mock_span.is_recording.return_value = False
|
|
mock_tracer.start_span.return_value = mock_span
|
|
mock_tracer.use_span.return_value.__enter__ = mock_span
|
|
mock_tracer.use_span.return_value.__exit__ = True
|
|
with mock.patch("opentelemetry.trace.get_tracer") as tracer:
|
|
tracer.return_value = mock_tracer
|
|
engine = create_engine("sqlite:///:memory:")
|
|
SQLAlchemyInstrumentor().instrument(
|
|
engine=engine, tracer_provider=self.tracer_provider,
|
|
)
|
|
cnx = engine.connect()
|
|
cnx.execute("SELECT 1 + 1;").fetchall()
|
|
self.assertFalse(mock_span.is_recording())
|
|
self.assertTrue(mock_span.is_recording.called)
|
|
self.assertFalse(mock_span.set_attribute.called)
|
|
self.assertFalse(mock_span.set_status.called)
|
|
|
|
def test_create_engine_wrapper(self):
|
|
SQLAlchemyInstrumentor().instrument()
|
|
from sqlalchemy import create_engine # pylint: disable-all
|
|
|
|
engine = create_engine("sqlite:///:memory:")
|
|
cnx = engine.connect()
|
|
cnx.execute("SELECT 1 + 1;").fetchall()
|
|
spans = self.memory_exporter.get_finished_spans()
|
|
|
|
self.assertEqual(len(spans), 1)
|
|
self.assertEqual(spans[0].name, "SELECT 1 + 1;")
|
|
self.assertEqual(spans[0].kind, trace.SpanKind.CLIENT)
|