Protect access to Span implementation (#1188)

This commit is contained in:
Amos Law
2020-10-06 17:44:41 -04:00
committed by alrex
parent 09bef3e41a
commit ed68634b9d

View File

@ -42,7 +42,7 @@ class TestUtils(unittest.TestCase):
"routing_key": "celery",
}
span = trace.Span("name", mock.Mock(spec=trace_api.SpanContext))
span = trace._Span("name", mock.Mock(spec=trace_api.SpanContext))
utils.set_attributes_from_context(span, context)
self.assertEqual(
@ -78,7 +78,7 @@ class TestUtils(unittest.TestCase):
"retries": 0,
}
span = trace.Span("name", mock.Mock(spec=trace_api.SpanContext))
span = trace._Span("name", mock.Mock(spec=trace_api.SpanContext))
utils.set_attributes_from_context(span, context)
self.assertEqual(len(span.attributes), 0)
@ -99,7 +99,7 @@ class TestUtils(unittest.TestCase):
# propagate and retrieve a Span
task_id = "7c6731af-9533-40c3-83a9-25b58f0d837f"
span = trace.Span("name", mock.Mock(spec=trace_api.SpanContext))
span = trace._Span("name", mock.Mock(spec=trace_api.SpanContext))
utils.attach_span(fn_task, task_id, span)
span_after = utils.retrieve_span(fn_task, task_id)
self.assertIs(span, span_after)
@ -112,7 +112,7 @@ class TestUtils(unittest.TestCase):
# propagate a Span
task_id = "7c6731af-9533-40c3-83a9-25b58f0d837f"
span = trace.Span("name", mock.Mock(spec=trace_api.SpanContext))
span = trace._Span("name", mock.Mock(spec=trace_api.SpanContext))
utils.attach_span(fn_task, task_id, span)
# delete the Span
utils.detach_span(fn_task, task_id)