opensource/opentelemetry-python-contrib
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-python-contrib.git synced 2025-08-02 02:52:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

Update pymongo instrumentation to follow semantic conventions

Browse Source
This commit is contained in:
Srikanth Chekuri
2020-11-22 01:21:36 +05:30
parent 9bf7c48e3f
commit d51636e2c0
3 changed files with 11 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
instrumentation/opentelemetry-instrumentation-pymongo/tests/test_pymongo.py
View File

@ -39,10 +39,6 @@ class TestPymongo(TestBase):
def test_started(self):
command_attrs = {
"filter": "filter",
"sort": "sort",
"limit": "limit",
"pipeline": "pipeline",
"command_name": "find",
}
command_tracer = CommandTracer(self.tracer)
@ -55,24 +51,12 @@ class TestPymongo(TestBase):
# pylint: disable=protected-access
span = command_tracer._pop_span(mock_event)
self.assertIs(span.kind, trace_api.SpanKind.CLIENT)
self.assertEqual(span.name, "mongodb.command_name.find")
self.assertEqual(span.attributes["component"], "mongodb")
self.assertEqual(span.attributes["db.type"], "mongodb")
self.assertEqual(span.attributes["db.instance"], "database_name")
self.assertEqual(span.name, "command_name.find")
self.assertEqual(span.attributes["db.system"], "mongodb")
self.assertEqual(span.attributes["db.name"], "database_name")
self.assertEqual(span.attributes["db.statement"], "command_name find")
self.assertEqual(span.attributes["net.peer.name"], "test.com")
self.assertEqual(span.attributes["net.peer.port"], "1234")
self.assertEqual(
span.attributes["db.mongo.operation_id"], "operation_id"
)
self.assertEqual(
span.attributes["db.mongo.request_id"], "test_request_id"
)
self.assertEqual(span.attributes["db.mongo.filter"], "filter")
self.assertEqual(span.attributes["db.mongo.sort"], "sort")
self.assertEqual(span.attributes["db.mongo.limit"], "limit")
self.assertEqual(span.attributes["db.mongo.pipeline"], "pipeline")
def test_succeeded(self):
mock_event = MockEvent({})
@ -82,9 +66,6 @@ class TestPymongo(TestBase):
spans_list = self.memory_exporter.get_finished_spans()
self.assertEqual(len(spans_list), 1)
span = spans_list[0]
self.assertEqual(
span.attributes["db.mongo.duration_micros"], "duration_micros"
)
self.assertIs(
span.status.status_code, trace_api.status.StatusCode.UNSET
)
@ -116,9 +97,6 @@ class TestPymongo(TestBase):
self.assertEqual(len(spans_list), 1)
span = spans_list[0]
self.assertEqual(
span.attributes["db.mongo.duration_micros"], "duration_micros"
)
self.assertIs(
span.status.status_code, trace_api.status.StatusCode.ERROR,
)
@ -139,13 +117,9 @@ class TestPymongo(TestBase):
first_span = spans_list[0]
second_span = spans_list[1]
self.assertEqual(first_span.attributes["db.mongo.request_id"], "first")
self.assertIs(
first_span.status.status_code, trace_api.status.StatusCode.UNSET,
)
self.assertEqual(
second_span.attributes["db.mongo.request_id"], "second"
)
self.assertIs(
second_span.status.status_code, trace_api.status.StatusCode.ERROR,
)
@ -165,7 +139,7 @@ class TestPymongo(TestBase):
self.assertEqual(len(spans_list), 1)
span = spans_list[0]
self.assertEqual(span.name, "mongodb.command_name.123")
self.assertEqual(span.name, "command_name.123")
class MockCommand: