opensource/opentelemetry-python-contrib
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-python-contrib.git synced 2025-07-31 22:23:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

Align sampling specs in SDK (#1034)

Browse Source
This commit is contained in:
Leighton Chen
2020-08-31 12:07:32 -07:00
committed by GitHub
parent 02d48caf17
commit cec9b5508c
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
exporter/opentelemetry-exporter-datadog/src/opentelemetry/exporter/datadog/exporter.py
View File

@ -247,7 +247,7 @@ def _get_sampling_rate(span):
return ( return (
span.sampler.rate span.sampler.rate
if ctx.trace_flags.sampled if ctx.trace_flags.sampled
and isinstance(span.sampler, sampling.ProbabilitySampler) and isinstance(span.sampler, sampling.TraceIdRatioBased)
else None else None
) )

2
exporter/opentelemetry-exporter-datadog/tests/test_datadog_exporter.py
View File

@ -498,7 +498,7 @@ class TestDatadogSpanExporter(unittest.TestCase):
is_remote=False, is_remote=False,
trace_flags=trace_api.TraceFlags(trace_api.TraceFlags.SAMPLED), trace_flags=trace_api.TraceFlags(trace_api.TraceFlags.SAMPLED),
) )
sampler = sampling.ProbabilitySampler(0.5) sampler = sampling.TraceIdRatioBased(0.5)
span = trace.Span( span = trace.Span(
name="sampled", context=context, parent=None, sampler=sampler name="sampled", context=context, parent=None, sampler=sampler