From cc2e7d276bcd19c446b01ab3fcf2f3db268f5d8f Mon Sep 17 00:00:00 2001 From: Owais Lone Date: Tue, 12 Oct 2021 01:43:32 +0530 Subject: [PATCH] Fix mssql docker tests v2 (#723) * Pin ubuntu to 20.04 in CI * Fix mssql docker tests --- .github/workflows/test.yml | 11 +++++++++-- .../tests/docker-compose.yml | 4 ++-- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 833acd981..13f9d4d76 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -24,7 +24,7 @@ jobs: matrix: python-version: [ py36, py37, py38, py39, pypy3 ] package: ["instrumentation", "exporter", "sdkextension", "propagator"] - os: [ ubuntu-latest ] + os: [ ubuntu-20.04 ] steps: - name: Checkout Contrib Repo @ SHA - ${{ github.sha }} uses: actions/checkout@v2 @@ -74,7 +74,7 @@ jobs: matrix: tox-environment: [ "docker-tests", "lint", "docs", "generate" ] name: ${{ matrix.tox-environment }} - runs-on: ubuntu-latest + runs-on: ubuntu-20.04 steps: - name: Checkout Contrib Repo @ SHA - ${{ github.sha }} uses: actions/checkout@v2 @@ -84,6 +84,13 @@ jobs: python-version: 3.9 - name: Install tox run: pip install -U tox + - name: Prep mssql driver + if: ${{ matrix.tox-environment == 'docker-tests' }} + run: | + curl https://packages.microsoft.com/keys/microsoft.asc | sudo apt-key add - + sudo sh -c "echo 'deb [arch=amd64,armhf,arm64] https://packages.microsoft.com/ubuntu/20.04/prod focal main' > /etc/apt/sources.list.d/mssql-release.list" + sudo apt-get update + sudo ACCEPT_EULA=Y apt-get install -y msodbcsql17 - name: Install libsnappy-dev if: ${{ matrix.tox-environment == 'lint' }} run: sudo apt-get install -y libsnappy-dev diff --git a/tests/opentelemetry-docker-tests/tests/docker-compose.yml b/tests/opentelemetry-docker-tests/tests/docker-compose.yml index 97d62522c..047a27177 100644 --- a/tests/opentelemetry-docker-tests/tests/docker-compose.yml +++ b/tests/opentelemetry-docker-tests/tests/docker-compose.yml @@ -40,10 +40,10 @@ services: - "14268:14268" - "9411:9411" otmssql: - image: mcr.microsoft.com/mssql/server:2017-latest + image: mcr.microsoft.com/mssql/server:2017-CU23-ubuntu-16.04 ports: - "1433:1433" environment: ACCEPT_EULA: "Y" SA_PASSWORD: "yourStrong(!)Password" - command: /bin/sh -c "sleep 10s && /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P yourStrong\(!\)Password -d master -Q 'CREATE DATABASE [opentelemetry-tests]' & /opt/mssql/bin/sqlservr" \ No newline at end of file + command: /bin/sh -c "sleep 10s && /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P yourStrong\(!\)Password -d master -Q 'CREATE DATABASE [opentelemetry-tests]' & /opt/mssql/bin/sqlservr"