opensource/opentelemetry-python-contrib
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-python-contrib.git synced 2025-08-01 17:34:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

urllib: don't assume we control the bucket metrics data point get in (#3341)

Browse Source 
Instead of expecting an entry in a specific bucket, just sum all of them
and assert we have the correct number of entries.

Co-authored-by: Shalev Roda <65566801+shalevr@users.noreply.github.com>
This commit is contained in:
Riccardo Magliocchetti
2025-03-06 13:10:51 +01:00
committed by GitHub
parent 65720812f7
commit c0132c6ab0
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
instrumentation/opentelemetry-instrumentation-urllib/tests/test_metrics_instrumentation.py
View File

@ -414,16 +414,16 @@ class TestUrllibMetricsInstrumentation(TestBase):
) = metrics[:3] ) = metrics[:3]
self.assertEqual( self.assertEqual(
client_duration.data.data_points[0].bucket_counts[1], sum(client_duration.data.data_points[0].bucket_counts),
1, 1,
) )
self.assertEqual( self.assertEqual(
client_request_size.data.data_points[0].bucket_counts[0], sum(client_request_size.data.data_points[0].bucket_counts),
1, 1,
) )
self.assertEqual( self.assertEqual(
client_response_size.data.data_points[0].bucket_counts[2], sum(client_response_size.data.data_points[0].bucket_counts),
1, 1,
) )
@ -439,15 +439,15 @@ class TestUrllibMetricsInstrumentation(TestBase):
) = metrics[:3] ) = metrics[:3]
self.assertEqual( self.assertEqual(
client_duration.data.data_points[0].bucket_counts[1], sum(client_duration.data.data_points[0].bucket_counts),
2, 2,
) )
self.assertEqual( self.assertEqual(
client_request_size.data.data_points[0].bucket_counts[0], sum(client_request_size.data.data_points[0].bucket_counts),
2, 2,
) )
self.assertEqual( self.assertEqual(
client_response_size.data.data_points[0].bucket_counts[2], sum(client_response_size.data.data_points[0].bucket_counts),
2, 2,
) )
@ -467,15 +467,15 @@ class TestUrllibMetricsInstrumentation(TestBase):
self.assertEqual(len(metrics), 3) self.assertEqual(len(metrics), 3)
self.assertEqual( self.assertEqual(
client_duration.data.data_points[0].bucket_counts[1], sum(client_duration.data.data_points[0].bucket_counts),
2, 2,
) )
self.assertEqual( self.assertEqual(
client_request_size.data.data_points[0].bucket_counts[0], sum(client_request_size.data.data_points[0].bucket_counts),
2, 2,
) )
self.assertEqual( self.assertEqual(
client_response_size.data.data_points[0].bucket_counts[2], sum(client_response_size.data.data_points[0].bucket_counts),
2, 2,
) )