mirror of
https://github.com/open-telemetry/opentelemetry-python-contrib.git
synced 2025-08-05 22:09:56 +08:00
Implement checking for suppression key in pymongo instrumentation (#736)
* Implement checking for suppression key Add test for suppression key with pymongo changelog update * Linting * pylint * Bad reformat * Update changelog with PR Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com>
This commit is contained in:
@ -14,11 +14,13 @@
|
||||
|
||||
from unittest import mock
|
||||
|
||||
from opentelemetry import context
|
||||
from opentelemetry import trace as trace_api
|
||||
from opentelemetry.instrumentation.pymongo import (
|
||||
CommandTracer,
|
||||
PymongoInstrumentor,
|
||||
)
|
||||
from opentelemetry.instrumentation.utils import _SUPPRESS_INSTRUMENTATION_KEY
|
||||
from opentelemetry.semconv.trace import SpanAttributes
|
||||
from opentelemetry.test.test_base import TestBase
|
||||
|
||||
@ -90,6 +92,31 @@ class TestPymongo(TestBase):
|
||||
self.assertFalse(mock_span.set_attribute.called)
|
||||
self.assertFalse(mock_span.set_status.called)
|
||||
|
||||
def test_suppression_key(self):
|
||||
mock_tracer = mock.Mock()
|
||||
mock_span = mock.Mock()
|
||||
mock_span.is_recording.return_value = True
|
||||
mock_tracer.start_span.return_value = mock_span
|
||||
mock_event = MockEvent({})
|
||||
mock_event.command.get = mock.Mock()
|
||||
mock_event.command.get.return_value = "dummy"
|
||||
|
||||
token = context.attach(
|
||||
context.set_value(_SUPPRESS_INSTRUMENTATION_KEY, True)
|
||||
)
|
||||
|
||||
try:
|
||||
command_tracer = CommandTracer(mock_tracer)
|
||||
command_tracer.started(event=mock_event)
|
||||
command_tracer.succeeded(event=mock_event)
|
||||
finally:
|
||||
context.detach(token)
|
||||
|
||||
# if suppression key is set, CommandTracer methods return immediately, so command.get is not invoked.
|
||||
self.assertFalse(
|
||||
mock_event.command.get.called # pylint: disable=no-member
|
||||
)
|
||||
|
||||
def test_failed(self):
|
||||
mock_event = MockEvent({})
|
||||
command_tracer = CommandTracer(self.tracer)
|
||||
|
Reference in New Issue
Block a user