opensource/opentelemetry-python-contrib
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-python-contrib.git synced 2025-08-02 19:47:17 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix requests and urllib instrumentations span name callback parameters (#259)

Browse Source
This commit is contained in:
Leighton Chen
2020-12-16 11:17:23 -05:00
committed by GitHub
parent 187987d9cc
commit 65801c31d8
5 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
instrumentation/opentelemetry-instrumentation-requests/tests/test_requests_integration.py
View File

@ -108,8 +108,8 @@ class RequestsIntegrationTestBase(abc.ABC):
self.assertGreaterEqual(view_data.aggregator.current.sum, 0)
def test_name_callback(self):
def name_callback():
return "test_name"
def name_callback(method, url):
return "GET" + url
RequestsInstrumentor().uninstrument()
RequestsInstrumentor().instrument(name_callback=name_callback)
@ -117,10 +117,10 @@ class RequestsIntegrationTestBase(abc.ABC):
self.assertEqual(result.text, "Hello!")
span = self.assert_span()
self.assertEqual(span.name, "test_name")
self.assertEqual(span.name, "GET" + self.URL)
def test_name_callback_default(self):
def name_callback():
def name_callback(method, url):
return 123
RequestsInstrumentor().uninstrument()