opensource/opentelemetry-python-contrib
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-python-contrib.git synced 2025-07-30 13:43:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove db.name attribute from Redis instrumentation (#1427)

Browse Source
This commit is contained in:
luke6Lh43
2022-11-10 20:21:44 +01:00
committed by GitHub
parent 7acc336cca
commit 5f85a5bd74
3 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/opentelemetry-docker-tests/tests/redis/test_redis_functional.py
View File

@ -37,7 +37,9 @@ class TestRedisInstrument(TestBase):
def _check_span(self, span, name):
self.assertEqual(span.name, name)
self.assertIs(span.status.status_code, trace.StatusCode.UNSET)
self.assertEqual(span.attributes.get(SpanAttributes.DB_NAME), 0)
self.assertEqual(
span.attributes.get(SpanAttributes.DB_REDIS_DATABASE_INDEX), 0
)
self.assertEqual(
span.attributes[SpanAttributes.NET_PEER_NAME], "localhost"
)
@ -209,7 +211,9 @@ class TestAsyncRedisInstrument(TestBase):
def _check_span(self, span, name):
self.assertEqual(span.name, name)
self.assertIs(span.status.status_code, trace.StatusCode.UNSET)
self.assertEqual(span.attributes.get(SpanAttributes.DB_NAME), 0)
self.assertEqual(
span.attributes.get(SpanAttributes.DB_REDIS_DATABASE_INDEX), 0
)
self.assertEqual(
span.attributes[SpanAttributes.NET_PEER_NAME], "localhost"
)