opensource/opentelemetry-python-contrib
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-python-contrib.git synced 2025-07-31 22:23:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

Change status codes from grpc status codes, remove setting status in instrumentations except on ERROR (#1282)

Browse Source
This commit is contained in:
Leighton Chen
2020-10-28 17:28:58 -04:00
committed by GitHub
parent 20a3a160bb
commit 5cab8136f7
2 changed files with 4 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
instrumentation/opentelemetry-instrumentation-dbapi/src/opentelemetry/instrumentation/dbapi/__init__.py
View File

@ -50,7 +50,7 @@ from opentelemetry import trace as trace_api
from opentelemetry.instrumentation.dbapi.version import __version__ from opentelemetry.instrumentation.dbapi.version import __version__
from opentelemetry.instrumentation.utils import unwrap from opentelemetry.instrumentation.utils import unwrap
from opentelemetry.trace import SpanKind, TracerProvider, get_tracer from opentelemetry.trace import SpanKind, TracerProvider, get_tracer
from opentelemetry.trace.status import Status, StatusCanonicalCode from opentelemetry.trace.status import Status, StatusCode
logger = logging.getLogger(__name__) logger = logging.getLogger(__name__)
@ -343,14 +343,10 @@ class TracedCursor:
self._populate_span(span, *args) self._populate_span(span, *args)
try: try:
result = query_method(*args, **kwargs) result = query_method(*args, **kwargs)
if span.is_recording():
span.set_status(Status(StatusCanonicalCode.OK))
return result return result
except Exception as ex: # pylint: disable=broad-except except Exception as ex: # pylint: disable=broad-except
if span.is_recording(): if span.is_recording():
span.set_status( span.set_status(Status(StatusCode.ERROR, str(ex)))
Status(StatusCanonicalCode.UNKNOWN, str(ex))
)
raise ex raise ex

6
instrumentation/opentelemetry-instrumentation-dbapi/tests/test_dbapi_integration.py
View File

@ -65,8 +65,7 @@ class TestDBApiIntegration(TestBase):
self.assertEqual(span.attributes["net.peer.name"], "testhost") self.assertEqual(span.attributes["net.peer.name"], "testhost")
self.assertEqual(span.attributes["net.peer.port"], 123) self.assertEqual(span.attributes["net.peer.port"], 123)
self.assertIs( self.assertIs(
span.status.canonical_code, span.status.status_code, trace_api.status.StatusCode.UNSET,
trace_api.status.StatusCanonicalCode.OK,
) )
def test_span_not_recording(self): def test_span_not_recording(self):
@ -117,8 +116,7 @@ class TestDBApiIntegration(TestBase):
span = spans_list[0] span = spans_list[0]
self.assertEqual(span.attributes["db.statement"], "Test query") self.assertEqual(span.attributes["db.statement"], "Test query")
self.assertIs( self.assertIs(
span.status.canonical_code, span.status.status_code, trace_api.status.StatusCode.ERROR,
trace_api.status.StatusCanonicalCode.UNKNOWN,
) )
self.assertEqual(span.status.description, "Test Exception") self.assertEqual(span.status.description, "Test Exception")