From 4f79f80bc97f4a537a273625f6901855a58ff5b4 Mon Sep 17 00:00:00 2001 From: Leighton Date: Mon, 9 Nov 2020 10:35:30 -0500 Subject: [PATCH] test --- .../src/opentelemetry/instrumentation/requests/__init__.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/instrumentation/opentelemetry-instrumentation-requests/src/opentelemetry/instrumentation/requests/__init__.py b/instrumentation/opentelemetry-instrumentation-requests/src/opentelemetry/instrumentation/requests/__init__.py index db08e5e30..02128f944 100644 --- a/instrumentation/opentelemetry-instrumentation-requests/src/opentelemetry/instrumentation/requests/__init__.py +++ b/instrumentation/opentelemetry-instrumentation-requests/src/opentelemetry/instrumentation/requests/__init__.py @@ -125,9 +125,9 @@ def _instrument(tracer_provider=None, span_callback=None, name_callback=None): # https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/http.md#http-client method = method.upper() span_name = "" - if name_callback: + if name_callback is not None: span_name = name_callback() - if not span_name: + if not span_name or not isinstance(span_name, str): span_name = get_default_span_name(method) recorder = RequestsInstrumentor().metric_recorder