opensource/opentelemetry-python-contrib
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-python-contrib.git synced 2025-08-01 17:34:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use is_recording flag in aiopg, asyncpg, dbapi, psycopg2, pymemcache, pymongo, redis, sqlalchemy instrumentations (#1212)

Browse Source
This commit is contained in:
Leighton Chen
2020-10-08 15:25:20 -04:00
committed by GitHub
parent cdaf21e857
commit 2b829ee9fd
2 changed files with 45 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
instrumentation/opentelemetry-instrumentation-pymongo/src/opentelemetry/instrumentation/pymongo/__init__.py
View File

@ -71,6 +71,7 @@ class CommandTracer(monitoring.CommandListener):
try:
span = self._tracer.start_span(name, kind=SpanKind.CLIENT)
if span.is_recording():
span.set_attribute("component", DATABASE_TYPE)
span.set_attribute("db.type", DATABASE_TYPE)
span.set_attribute("db.instance", event.database_name)
@ -92,7 +93,10 @@ class CommandTracer(monitoring.CommandListener):
self._span_dict[_get_span_dict_key(event)] = span
except Exception as ex: # noqa pylint: disable=broad-except
if span is not None:
span.set_status(Status(StatusCanonicalCode.INTERNAL, str(ex)))
if span.is_recording():
span.set_status(
Status(StatusCanonicalCode.INTERNAL, str(ex))
)
span.end()
self._pop_span(event)
@ -103,7 +107,10 @@ class CommandTracer(monitoring.CommandListener):
span = self._pop_span(event)
if span is None:
return
span.set_attribute("db.mongo.duration_micros", event.duration_micros)
if span.is_recording():
span.set_attribute(
"db.mongo.duration_micros", event.duration_micros
)
span.set_status(Status(StatusCanonicalCode.OK, event.reply))
span.end()
@ -114,7 +121,10 @@ class CommandTracer(monitoring.CommandListener):
span = self._pop_span(event)
if span is None:
return
span.set_attribute("db.mongo.duration_micros", event.duration_micros)
if span.is_recording():
span.set_attribute(
"db.mongo.duration_micros", event.duration_micros
)
span.set_status(Status(StatusCanonicalCode.UNKNOWN, event.failure))
span.end()

16
instrumentation/opentelemetry-instrumentation-pymongo/tests/test_pymongo.py
View File

@ -91,6 +91,22 @@ class TestPymongo(TestBase):
self.assertEqual(span.status.description, "reply")
self.assertIsNotNone(span.end_time)
def test_not_recording(self):
mock_tracer = mock.Mock()
mock_span = mock.Mock()
mock_span.is_recording.return_value = False
mock_tracer.start_span.return_value = mock_span
mock_tracer.use_span.return_value.__enter__ = mock_span
mock_tracer.use_span.return_value.__exit__ = True
mock_event = MockEvent({})
command_tracer = CommandTracer(mock_tracer)
command_tracer.started(event=mock_event)
command_tracer.succeeded(event=mock_event)
self.assertFalse(mock_span.is_recording())
self.assertTrue(mock_span.is_recording.called)
self.assertFalse(mock_span.set_attribute.called)
self.assertFalse(mock_span.set_status.called)
def test_failed(self):
mock_event = MockEvent({})
command_tracer = CommandTracer(self.tracer)