opensource/opentelemetry-python-contrib
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-python-contrib.git synced 2025-07-29 13:12:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

Expand sqlalchemy pool.name to follow the semantic conventions (#1778)

Browse Source
This commit is contained in:
Shalev Roda
2023-05-06 20:39:52 +03:00
committed by GitHub
parent 890e5dd9b8
commit 1a1163e919
4 changed files with 51 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
instrumentation/opentelemetry-instrumentation-sqlalchemy/tests/test_sqlalchemy_metrics.py
View File

@ -70,11 +70,12 @@ class TestSqlalchemyMetricsInstrumentation(TestBase):
)
def test_metrics_without_pool_name(self):
pool_name = ""
pool_name = "pool_test_name"
engine = sqlalchemy.create_engine(
"sqlite:///:memory:",
pool_size=5,
poolclass=QueuePool,
pool_logging_name=pool_name,
)
metrics = self.get_sorted_metrics()