From 3175e7a7f38280f6ca0d8129abd46debcdd54c74 Mon Sep 17 00:00:00 2001 From: Grant Sanderson Date: Wed, 7 Feb 2018 16:20:16 -0800 Subject: [PATCH 1/5] Tiny cosmetic changes to transform --- animation/transform.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/animation/transform.py b/animation/transform.py index 799b776f..30d7c7d2 100644 --- a/animation/transform.py +++ b/animation/transform.py @@ -22,8 +22,9 @@ class Transform(Animation): #Copy target_mobject so as to not mess with caller self.original_target_mobject = target_mobject target_mobject = target_mobject.copy() - digest_config(self, kwargs, locals()) mobject.align_data(target_mobject) + self.target_mobject = target_mobject + digest_config(self, kwargs) self.init_path_func() Animation.__init__(self, mobject, **kwargs) @@ -40,7 +41,7 @@ class Transform(Animation): def init_path_func(self): if self.path_func is not None: return - if self.path_arc == 0: + elif self.path_arc == 0: self.path_func = straight_path else: self.path_func = path_along_arc( From 81b8aff7bddc800168d611fa0dd7aace84fe6b3e Mon Sep 17 00:00:00 2001 From: Grant Sanderson Date: Wed, 7 Feb 2018 16:20:35 -0800 Subject: [PATCH 2/5] Added print_mobject_family --- helpers.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/helpers.py b/helpers.py index 0c97c556..bdf54365 100644 --- a/helpers.py +++ b/helpers.py @@ -666,3 +666,10 @@ class DictAsObject(object): # Just to have a less heavyweight name for this extremely common operation def fdiv(a, b): return np.true_divide(a,b) + +# For debugging purposes + +def print_mobject_family(mob, n_tabs = 0): + print "\t"*n_tabs, mob, id(mob) + for submob in mob.submobjects: + print_mobject_family(submob, n_tabs + 1) From dca03648ad0a1d580e066244e74ac7bb2055857c Mon Sep 17 00:00:00 2001 From: Grant Sanderson Date: Wed, 7 Feb 2018 16:21:11 -0800 Subject: [PATCH 3/5] Tiny changes to mobject --- mobject/mobject.py | 8 ++++---- mobject/vectorized_mobject.py | 3 ++- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/mobject/mobject.py b/mobject/mobject.py index 53509d0e..0f493b19 100644 --- a/mobject/mobject.py +++ b/mobject/mobject.py @@ -770,10 +770,10 @@ class Mobject(Container): self.null_point_align(mobject) self_count = len(self.submobjects) mob_count = len(mobject.submobjects) - diff = abs(self_count-mob_count) - if self_count < mob_count: - self.add_n_more_submobjects(diff) - elif mob_count < self_count: + diff = self_count-mob_count + if diff < 0: + self.add_n_more_submobjects(-diff) + elif diff > 0: mobject.add_n_more_submobjects(diff) return self diff --git a/mobject/vectorized_mobject.py b/mobject/vectorized_mobject.py index c64851fb..a3eee4d4 100644 --- a/mobject/vectorized_mobject.py +++ b/mobject/vectorized_mobject.py @@ -42,7 +42,8 @@ class VMobject(Mobject): stroke_width = None, fill_color = None, fill_opacity = None, - family = True): + family = True + ): if stroke_color is not None: self.stroke_rgb = color_to_rgb(stroke_color) if fill_color is not None: From 29962068dbb36a081398593d936e4500ce1d76f8 Mon Sep 17 00:00:00 2001 From: Grant Sanderson Date: Wed, 7 Feb 2018 16:21:28 -0800 Subject: [PATCH 4/5] Bug fix to Line.insert_n_anchor_points --- topics/geometry.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/topics/geometry.py b/topics/geometry.py index 2312e74b..8e3f910b 100644 --- a/topics/geometry.py +++ b/topics/geometry.py @@ -356,7 +356,7 @@ class Line(VMobject): def insert_n_anchor_points(self, n): if not self.path_arc: n_anchors = self.get_num_anchor_points() - new_num_points = 3*(n_anchors + n)+1 + new_num_points = 3*(n_anchors + n)-2 self.points = np.array([ self.point_from_proportion(alpha) for alpha in np.linspace(0, 1, new_num_points) From ff32a7c6a4113a0bd1bd15a98f2e9b4a5f1de902 Mon Sep 17 00:00:00 2001 From: Ben Hambrecht Date: Thu, 8 Feb 2018 12:05:46 +0100 Subject: [PATCH 5/5] ignoring PyCharm's config files --- .gitignore | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.gitignore b/.gitignore index f0f3ca3f..27a36fe4 100644 --- a/.gitignore +++ b/.gitignore @@ -9,3 +9,7 @@ files/ ben_playground.py ben_cairo_test.py + +*.xml + +*.iml