opensource/lexical
1
0
Fork 0
mirror of https://github.com/facebook/lexical.git synced 2025-08-23 08:13:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

[lexical-code][lexical-playground] Bug Fix: Fix selection boundaries in code block (#7187)

Browse Source
This commit is contained in:
Kiran Dash
2025-02-17 06:44:01 +08:00
committed by GitHub
parent e5f3c0cee5
commit f3983c5123
2 changed files with 207 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

58
packages/lexical-code/src/CodeHighlighter.ts
View File

@ -880,22 +880,64 @@ export function registerCodeHighlighting(
),
editor.registerCommand(
KEY_ARROW_UP_COMMAND,
(payload): boolean => $handleShiftLines(KEY_ARROW_UP_COMMAND, payload),
(event) => {
const selection = $getSelection();
if (!$isRangeSelection(selection)) {
return false;
}
const {anchor} = selection;
const anchorNode = anchor.getNode();
if (!$isSelectionInCode(selection)) {
return false;
}
// If at the start of a code block, prevent selection from moving out
if (
selection.isCollapsed() &&
anchor.offset === 0 &&
anchorNode.getPreviousSibling() === null &&
$isCodeNode(anchorNode.getParentOrThrow())
) {
event.preventDefault();
return true;
}
return $handleShiftLines(KEY_ARROW_UP_COMMAND, event);
},
COMMAND_PRIORITY_LOW,
),
editor.registerCommand(
KEY_ARROW_DOWN_COMMAND,
(payload): boolean => $handleShiftLines(KEY_ARROW_DOWN_COMMAND, payload),
COMMAND_PRIORITY_LOW,
),
editor.registerCommand(
MOVE_TO_END,
(payload): boolean => $handleMoveTo(MOVE_TO_END, payload),
(event) => {
const selection = $getSelection();
if (!$isRangeSelection(selection)) {
return false;
}
const {anchor} = selection;
const anchorNode = anchor.getNode();
if (!$isSelectionInCode(selection)) {
return false;
}
// If at the end of a code block, prevent selection from moving out
if (
selection.isCollapsed() &&
anchor.offset === anchorNode.getTextContentSize() &&
anchorNode.getNextSibling() === null &&
$isCodeNode(anchorNode.getParentOrThrow())
) {
event.preventDefault();
return true;
}
return $handleShiftLines(KEY_ARROW_DOWN_COMMAND, event);
},
COMMAND_PRIORITY_LOW,
),
editor.registerCommand(
MOVE_TO_START,
(payload): boolean => $handleMoveTo(MOVE_TO_START, payload),
(event) => $handleMoveTo(MOVE_TO_START, event as KeyboardEvent),
COMMAND_PRIORITY_LOW,
),
editor.registerCommand(
MOVE_TO_END,
(event) => $handleMoveTo(MOVE_TO_END, event as KeyboardEvent),
COMMAND_PRIORITY_LOW,
),
);