opensource/lexical
1
0
Fork 0
mirror of https://github.com/facebook/lexical.git synced 2025-08-06 16:39:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

[*] Chore: Refactor shared/invariant for easier dev debugging (#7269)

Browse Source
This commit is contained in:
Bob Ippolito
2025-03-02 16:05:44 -08:00
committed by GitHub
parent 0b11dddb46
commit e6cc5d9199
5 changed files with 83 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files

110
scripts/error-codes/transform-error-messages.js
View File

@ -71,14 +71,14 @@ module.exports = function (babel, opts) {
//
// invariant(condition, 'A %s message that contains %s', adj, noun);
//
// into this:
// into something equivalent to this:
//
// if (!condition) {
// throw Error(
// __DEV__
// ? `A ${adj} message that contains ${noun}`
// : formatProdErrorMessage(ERR_CODE, adj, noun)
// );
// if (__DEV__ || ERR_CODE === undefined) {
// formatDevErrorMessage(`A ${adj} message that contains ${noun}`);
// } else {
// formatProdErrorMessage(ERR_CODE, adj, noun)
// };
// }
//
// where ERR_CODE is an error code: a unique identifier (a number
@ -113,24 +113,60 @@ module.exports = function (babel, opts) {
extractCodes,
);
if (noMinify) {
/** @type {babel.types.CallExpression} */
let callExpression;
if (noMinify || prodErrorId === undefined) {
// Error minification is disabled for this build.
//
// Outputs:
// if (!condition) {
// throw Error(`A ${adj} message that contains ${noun}`);
// formatDevErrorMessage(`A ${adj} message that contains ${noun}`);
// }
parentStatementPath.replaceWith(
t.ifStatement(
t.unaryExpression('!', condition),
t.blockStatement([
t.throwStatement(
t.callExpression(t.identifier('Error'), [devMessage]),
),
]),
),
const formatDevErrorMessageIdentifier =
helperModuleImports.addDefault(
path,
'shared/formatDevErrorMessage',
{
nameHint: 'formatDevErrorMessage',
},
);
callExpression = t.callExpression(formatDevErrorMessageIdentifier, [
devMessage,
]);
} else {
// Error minification enabled for this build.
//
// Outputs:
// if (!condition) {
// formatProdErrorMessage(ERR_CODE, adj, noun)
// }
// Import ReactErrorProd
const formatProdErrorMessageIdentifier =
helperModuleImports.addDefault(
path,
'shared/formatProdErrorMessage',
{
nameHint: 'formatProdErrorMessage',
},
);
// Outputs:
// formatProdErrorMessage(ERR_CODE, adj, noun);
callExpression = t.callExpression(
formatProdErrorMessageIdentifier,
[t.numericLiteral(prodErrorId), ...errorMsgExpressions],
);
} else if (prodErrorId === undefined) {
}
parentStatementPath.replaceWith(
t.ifStatement(
t.unaryExpression('!', condition),
t.blockStatement([t.expressionStatement(callExpression)]),
),
);
if (!noMinify && prodErrorId === undefined) {
// There is no error code for this message. Add an inline comment
// that flags this as an unminified error. This allows the build
// to proceed, while also allowing a post-build linter to detect it.
@ -138,48 +174,12 @@ module.exports = function (babel, opts) {
// Outputs:
// /* FIXME (minify-errors-in-prod): Unminified error message in production build! */
// if (!condition) {
// throw Error(`A ${adj} message that contains ${noun}`);
// formatDevErrorMessage(`A ${adj} message that contains ${noun}`);
// }
parentStatementPath.replaceWith(
t.ifStatement(
t.unaryExpression('!', condition),
t.blockStatement([
t.throwStatement(
t.callExpression(t.identifier('Error'), [devMessage]),
),
]),
),
);
parentStatementPath.addComment(
'leading',
'FIXME (minify-errors-in-prod): Unminified error message in production build!',
);
} else {
// Import ReactErrorProd
const formatProdErrorMessageIdentifier =
helperModuleImports.addDefault(path, 'formatProdErrorMessage', {
nameHint: 'formatProdErrorMessage',
});
// Outputs:
// formatProdErrorMessage(ERR_CODE, adj, noun);
const prodMessage = t.callExpression(
formatProdErrorMessageIdentifier,
[t.numericLiteral(prodErrorId), ...errorMsgExpressions],
);
// Outputs:
// if (!condition) {
// formatProdErrorMessage(ERR_CODE, adj, noun)
// }
parentStatementPath.replaceWith(
t.ifStatement(
t.unaryExpression('!', condition),
t.blockStatement([
t.blockStatement([t.expressionStatement(prodMessage)]),
]),
),
);
}
}
},