mirror of
https://github.com/facebook/lexical.git
synced 2025-08-06 16:39:33 +08:00
Introduce invariant error code system (#339)
This commit is contained in:

committed by
acywatson

parent
5f94878bad
commit
a457a3850d
147
scripts/error-codes/transform-error-messages.js
Normal file
147
scripts/error-codes/transform-error-messages.js
Normal file
@ -0,0 +1,147 @@
|
||||
/**
|
||||
* Copyright (c) Facebook, Inc. and its affiliates.
|
||||
*
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*/
|
||||
'use strict';
|
||||
|
||||
const fs = require('fs');
|
||||
const evalToString = require('./evalToString');
|
||||
const invertObject = require('./invertObject');
|
||||
const helperModuleImports = require('@babel/helper-module-imports');
|
||||
|
||||
module.exports = function (babel) {
|
||||
const t = babel.types;
|
||||
|
||||
return {
|
||||
visitor: {
|
||||
CallExpression(path, file) {
|
||||
const node = path.node;
|
||||
const noMinify = file.opts.noMinify;
|
||||
if (path.get('callee').isIdentifier({name: 'invariant'})) {
|
||||
// Turns this code:
|
||||
//
|
||||
// invariant(condition, 'A %s message that contains %s', adj, noun);
|
||||
//
|
||||
// into this:
|
||||
//
|
||||
// if (!condition) {
|
||||
// throw Error(
|
||||
// __DEV__
|
||||
// ? `A ${adj} message that contains ${noun}`
|
||||
// : formatProdErrorMessage(ERR_CODE, adj, noun)
|
||||
// );
|
||||
// }
|
||||
//
|
||||
// where ERR_CODE is an error code: a unique identifier (a number
|
||||
// string) that references a verbose error message. The mapping is
|
||||
// stored in `scripts/error-codes/codes.json`.
|
||||
const condition = node.arguments[0];
|
||||
const errorMsgLiteral = evalToString(node.arguments[1]);
|
||||
const errorMsgExpressions = Array.from(node.arguments.slice(2));
|
||||
const errorMsgQuasis = errorMsgLiteral
|
||||
.split('%s')
|
||||
.map((raw) => t.templateElement({raw, cooked: String.raw({raw})}));
|
||||
|
||||
// Outputs:
|
||||
// `A ${adj} message that contains ${noun}`;
|
||||
const devMessage = t.templateLiteral(
|
||||
errorMsgQuasis,
|
||||
errorMsgExpressions,
|
||||
);
|
||||
|
||||
const parentStatementPath = path.parentPath;
|
||||
if (parentStatementPath.type !== 'ExpressionStatement') {
|
||||
throw path.buildCodeFrameError(
|
||||
'invariant() cannot be called from expression context. Move ' +
|
||||
'the call to its own statement.',
|
||||
);
|
||||
}
|
||||
|
||||
if (noMinify) {
|
||||
// Error minification is disabled for this build.
|
||||
//
|
||||
// Outputs:
|
||||
// if (!condition) {
|
||||
// throw Error(`A ${adj} message that contains ${noun}`);
|
||||
// }
|
||||
parentStatementPath.replaceWith(
|
||||
t.ifStatement(
|
||||
t.unaryExpression('!', condition),
|
||||
t.blockStatement([
|
||||
t.throwStatement(
|
||||
t.callExpression(t.identifier('Error'), [devMessage]),
|
||||
),
|
||||
]),
|
||||
),
|
||||
);
|
||||
return;
|
||||
}
|
||||
|
||||
// Avoid caching because we write it as we go.
|
||||
const existingErrorMap = JSON.parse(
|
||||
fs.readFileSync(__dirname + '/codes.json', 'utf-8'),
|
||||
);
|
||||
const errorMap = invertObject(existingErrorMap);
|
||||
|
||||
let prodErrorId = errorMap[errorMsgLiteral];
|
||||
|
||||
if (prodErrorId === undefined) {
|
||||
// There is no error code for this message. Add an inline comment
|
||||
// that flags this as an unminified error. This allows the build
|
||||
// to proceed, while also allowing a post-build linter to detect it.
|
||||
//
|
||||
// Outputs:
|
||||
// /* FIXME (minify-errors-in-prod): Unminified error message in production build! */
|
||||
// if (!condition) {
|
||||
// throw Error(`A ${adj} message that contains ${noun}`);
|
||||
// }
|
||||
parentStatementPath.replaceWith(
|
||||
t.ifStatement(
|
||||
t.unaryExpression('!', condition),
|
||||
t.blockStatement([
|
||||
t.throwStatement(
|
||||
t.callExpression(t.identifier('Error'), [devMessage]),
|
||||
),
|
||||
]),
|
||||
),
|
||||
);
|
||||
parentStatementPath.addComment(
|
||||
'leading',
|
||||
'FIXME (minify-errors-in-prod): Unminified error message in production build!',
|
||||
);
|
||||
return;
|
||||
}
|
||||
prodErrorId = parseInt(prodErrorId, 10);
|
||||
|
||||
// Import ReactErrorProd
|
||||
const formatProdErrorMessageIdentifier =
|
||||
helperModuleImports.addDefault(path, 'formatProdErrorMessage', {
|
||||
nameHint: 'formatProdErrorMessage',
|
||||
});
|
||||
|
||||
// Outputs:
|
||||
// formatProdErrorMessage(ERR_CODE, adj, noun);
|
||||
const prodMessage = t.callExpression(
|
||||
formatProdErrorMessageIdentifier,
|
||||
[t.numericLiteral(prodErrorId), ...errorMsgExpressions],
|
||||
);
|
||||
|
||||
// Outputs:
|
||||
// if (!condition) {
|
||||
// formatProdErrorMessage(ERR_CODE, adj, noun)
|
||||
// }
|
||||
parentStatementPath.replaceWith(
|
||||
t.ifStatement(
|
||||
t.unaryExpression('!', condition),
|
||||
t.blockStatement([
|
||||
t.blockStatement([t.expressionStatement(prodMessage)]),
|
||||
]),
|
||||
),
|
||||
);
|
||||
}
|
||||
},
|
||||
},
|
||||
};
|
||||
};
|
Reference in New Issue
Block a user