opensource/lexical
1
0
Fork 0
mirror of https://github.com/facebook/lexical.git synced 2025-08-06 16:39:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

Move node registration to editor creation phase (#1252)

Browse Source 
* Move node registration to editor creation phase

* Fix OverflowedNode

* Fix unit test

* Fix bugs
This commit is contained in:
Dominic Gannaway
2022-02-09 19:24:55 +00:00
committed by acywatson
parent 95da4b502c
commit 055e6410be
49 changed files with 1512 additions and 1551 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
packages/lexical-react/src/LexicalTablePlugin.js
View File

@ -12,10 +12,11 @@ import type {ElementNode, CommandListenerEditorPriority} from 'lexical';
import {useEffect} from 'react';
import {useLexicalComposerContext} from '@lexical/react/LexicalComposerContext';
import {$log, $getSelection, $createParagraphNode} from 'lexical';
import {$createTableNodeWithDimensions} from '@lexical/helpers/nodes';
import {TableNode} from 'lexical/TableNode';
import {TableCellNode} from 'lexical/TableCellNode';
import {TableRowNode} from 'lexical/TableRowNode';
import {$createTableNodeWithDimensions} from '@lexical/helpers/nodes';
import invariant from 'shared/invariant';
const EditorPriority: CommandListenerEditorPriority = 0;
@ -23,7 +24,13 @@ export default function TablePlugin(): React$Node {
const [editor] = useLexicalComposerContext();
useEffect(() => {
const removeCommandListener = editor.addListener(
if (!editor.hasNodes([TableNode, TableCellNode, TableRowNode])) {
invariant(
false,
'TablePlugin: TableNode, TableCellNode or TableRowNode not registered on editor',
);
}
return editor.addListener(
'command',
(type, payload) => {
if (type === 'insertTable') {
@ -51,17 +58,6 @@ export default function TablePlugin(): React$Node {
},
EditorPriority,
);
const removeNodes = editor.registerNodes([
TableNode,
TableCellNode,
TableRowNode,
]);
return () => {
removeCommandListener();
removeNodes();
};
}, [editor]);
return null;