From f94d6a37b657d7923c7e54453b6b685827bdc19c Mon Sep 17 00:00:00 2001
From: Brian Tiger Chow <brian.holderchow@gmail.com>
Date: Mon, 27 Oct 2014 06:04:09 -0700
Subject: [PATCH] refactor(bitswap/message) use map to prevent duplicate
 entries

A nice invariant for bitswap sessions:

        Senders and receivers can trust that messages do not contain
        duplicate blocks or duplicate keys. Backing the message with a
        map enforces this invariant.

        This comes at the cost of O(n) getters.
---
 exchange/bitswap/message/message.go | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/exchange/bitswap/message/message.go b/exchange/bitswap/message/message.go
index d2ebd74b3..5d3aeb97d 100644
--- a/exchange/bitswap/message/message.go
+++ b/exchange/bitswap/message/message.go
@@ -28,12 +28,14 @@ type Exportable interface {
 
 // message wraps a proto message for convenience
 type message struct {
-	wantlist []u.Key
+	wantlist map[u.Key]struct{}
 	blocks   []blocks.Block
 }
 
-func New() *message {
-	return new(message)
+func New() BitSwapMessage {
+	return &message{
+		wantlist: make(map[u.Key]struct{}),
+	}
 }
 
 func newMessageFromProto(pbm pb.Message) BitSwapMessage {
@@ -50,7 +52,11 @@ func newMessageFromProto(pbm pb.Message) BitSwapMessage {
 
 // TODO(brian): convert these into keys
 func (m *message) Wantlist() []u.Key {
-	return m.wantlist
+	wl := make([]u.Key, 0)
+	for k, _ := range m.wantlist {
+		wl = append(wl, k)
+	}
+	return wl
 }
 
 // TODO(brian): convert these into blocks
@@ -59,7 +65,7 @@ func (m *message) Blocks() []blocks.Block {
 }
 
 func (m *message) AddWanted(k u.Key) {
-	m.wantlist = append(m.wantlist, k)
+	m.wantlist[k] = struct{}{}
 }
 
 func (m *message) AppendBlock(b blocks.Block) {